-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misleading label after creating model registry #3324
Fix misleading label after creating model registry #3324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manaswinidas do you mind adding a test case to frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx
to make sure we show the correct status when we have ContainerCreating?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3324 +/- ##
==========================================
- Coverage 84.84% 84.83% -0.02%
==========================================
Files 1307 1315 +8
Lines 29238 29494 +256
Branches 7902 8059 +157
==========================================
+ Hits 24808 25021 +213
- Misses 4430 4473 +43
... and 232 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @manaswinidas !!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-12278
Closes: RHOAIENG-13051
Description
Without this change the MR showed
Unavailable
immediately after creating model registry, when the reason wasContainerCreating
, which was misleading to the user.Before:
After:
Scrollable screens:
How Has This Been Tested?
ContainerCreating
the status of Model registry showsProgressing
instead ofUnavailable
.Unavailable
otherwise.Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main