Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading label after creating model registry #3324

Merged

Conversation

manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented Oct 11, 2024

Closes: RHOAIENG-12278
Closes: RHOAIENG-13051

Description

Without this change the MR showed Unavailable immediately after creating model registry, when the reason was ContainerCreating, which was misleading to the user.

Before:
Screenshot 2024-10-11 at 8 04 06 PM

Screenshot 2024-10-11 at 8 08 40 PM

After:
Screenshot 2024-10-11 at 7 54 42 PM

Scrollable screens:
Screenshot 2024-10-11 at 8 30 12 PM
Screenshot 2024-10-11 at 8 41 40 PM

How Has This Been Tested?

  1. Go to model registry setting page
  2. Try creating model registry, if the reason is ContainerCreating the status of Model registry shows Progressing instead of Unavailable.
  3. Show Unavailable otherwise.
  4. Check Projects tab in Permissions and check whether the project dropdown is scrollable
  5. Model Registry selector should be scrollable

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manaswinidas do you mind adding a test case to frontend/src/pages/modelRegistrySettings/__tests__/ModelRegistryTableRowStatus.spec.tsx to make sure we show the correct status when we have ContainerCreating?

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (33ea696) to head (8b81350).
Report is 40 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3324      +/-   ##
==========================================
- Coverage   84.84%   84.83%   -0.02%     
==========================================
  Files        1307     1315       +8     
  Lines       29238    29494     +256     
  Branches     7902     8059     +157     
==========================================
+ Hits        24808    25021     +213     
- Misses       4430     4473      +43     
Files with missing lines Coverage Δ
...ts/roleBinding/RoleBindingPermissionsNameInput.tsx 96.29% <ø> (ø)
...es/modelRegistry/screens/ModelRegistrySelector.tsx 61.01% <ø> (ø)
...elRegistrySettings/ModelRegistryTableRowStatus.tsx 98.79% <100.00%> (+3.73%) ⬆️

... and 232 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ea696...8b81350. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @manaswinidas !!

@openshift-ci openshift-ci bot added the lgtm label Oct 15, 2024
Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3f41512 into opendatahub-io:main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants