Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display internal addresses even when models are external #3333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Oct 15, 2024

Closes: RHOAIENG-7579

Description

This PR aims to display internal addresses even when models are external.

Screenshot 2024-10-15 at 5 03 33 PM Screenshot 2024-10-15 at 5 03 51 PM

How Has This Been Tested?

check the inference endpoint:
when external route is enabled:

  • it should display both internal and external address

when external route is not enabled

  • it should only show internal address

Test Impact

Added cypress tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti
Copy link
Contributor Author

ppadti commented Oct 15, 2024

@vconzola Could you please take a look at the above screenshots?

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.81%. Comparing base (3f41512) to head (4c2e1a9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3333      +/-   ##
==========================================
+ Coverage   84.79%   84.81%   +0.02%     
==========================================
  Files        1315     1315              
  Lines       29494    29494              
  Branches     8059     8059              
==========================================
+ Hits        25008    25015       +7     
+ Misses       4486     4479       -7     
Files with missing lines Coverage Δ
...erving/screens/global/InferenceServiceEndpoint.tsx 100.00% <100.00%> (ø)
...g/screens/global/InternalServicePopoverContent.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f41512...4c2e1a9. Read the comment docs.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested on a model with both enabled and only internal address enabled. Works fine

Screenshot 2024-10-15 at 8 22 48 PM

Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than i wonder if "Internal" should be lowercase in the buttons "Endpoint details (internal)" and "Endpoint details (internal and external)"

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gitdallas, manaswinidas
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mturley
Copy link
Contributor

mturley commented Oct 15, 2024

Also LGTM aside from @gitdallas 's nitpicks on capitalization @ppadti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants