-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display internal addresses even when models are external #3333
base: main
Are you sure you want to change the base?
Conversation
@vconzola Could you please take a look at the above screenshots? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3333 +/- ##
==========================================
+ Coverage 84.79% 84.81% +0.02%
==========================================
Files 1315 1315
Lines 29494 29494
Branches 8059 8059
==========================================
+ Hits 25008 25015 +7
+ Misses 4486 4479 -7
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm other than i wonder if "Internal" should be lowercase in the buttons "Endpoint details (internal)" and "Endpoint details (internal and external)"
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gitdallas, manaswinidas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also LGTM aside from @gitdallas 's nitpicks on capitalization @ppadti |
Closes: RHOAIENG-7579
Description
This PR aims to display internal addresses even when models are external.
How Has This Been Tested?
check the inference endpoint:
when external route is enabled:
when external route is not enabled
Test Impact
Added cypress tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main