Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all Clone code identifier to Duplicate #3334

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Oct 15, 2024

https://issues.redhat.com/browse/RHOAIENG-13771

Description

Rename all Pipeline items from "Clone" to "Duplicate". No functionality change.

How Has This Been Tested?

Manual check

  1. Verify the duplicate run created via pipeline version
  2. Verify the duplicate run created via experiment
  3. Verify the duplicate schedule run created via pipeline version
  4. Verify the duplicate schedule run created via expirement

Test Impact

Modified some cypress test path

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.82%. Comparing base (a15a69c) to head (5d5605b).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3334   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files        1315     1315           
  Lines       29492    29492           
  Branches     8057     8057           
=======================================
+ Hits        25016    25017    +1     
+ Misses       4476     4475    -1     
Files with missing lines Coverage Δ
...es/content/createRun/DuplicateRecurringRunPage.tsx 100.00% <100.00%> (ø)
...s/pipelines/content/createRun/DuplicateRunPage.tsx 100.00% <100.00%> (ø)
...c/concepts/pipelines/content/createRun/RunForm.tsx 98.07% <100.00%> (ø)
...c/concepts/pipelines/content/createRun/RunPage.tsx 100.00% <100.00%> (ø)
...ntent/createRun/contentSections/RunTypeSection.tsx 100.00% <100.00%> (ø)
...epts/pipelines/content/createRun/useRunFormData.ts 88.75% <100.00%> (ø)
...ecurringRun/PipelineRecurringRunDetailsActions.tsx 93.18% <ø> (ø)
...sDetails/pipelineRun/PipelineRunDetailsActions.tsx 79.62% <ø> (ø)
...elineRecurringRun/PipelineRecurringRunTableRow.tsx 100.00% <ø> (ø)
...content/tables/pipelineRun/PipelineRunTableRow.tsx 94.11% <100.00%> (ø)
... and 9 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15a69c...5d5605b. Read the comment docs.

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

clone routes still working

@manosnoam FYI data test IDs were changed as a result of this PR

Copy link
Contributor

openshift-ci bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ecf36fc into opendatahub-io:main Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants