Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/12783-error-for-dup-model-name #3708

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitdallas
Copy link
Contributor

fises: https://issues.redhat.com/browse/RHOAIENG-12783

Description

model name field will check against existing names and give an error help text if it matches one, it will also prevent form submission
image

How Has This Been Tested?

tested locally by using duplicate model name while trying to register a new model

Test Impact

added a test to check that duplicate model name prevents form submission

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from manaswinidas and ppadti January 31, 2025 23:22
Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gitdallas gitdallas requested a review from mturley January 31, 2025 23:22
@gitdallas gitdallas force-pushed the fix/error-for-dupe-model-name branch from 22bc434 to 63af785 Compare February 3, 2025 13:54
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (c2f8933) to head (63af785).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
- Coverage   84.89%   84.89%   -0.01%     
==========================================
  Files        1456     1456              
  Lines       33815    33822       +7     
  Branches     9382     9387       +5     
==========================================
+ Hits        28707    28712       +5     
- Misses       5108     5110       +2     
Files with missing lines Coverage Δ
...elRegistry/screens/RegisterModel/RegisterModel.tsx 83.72% <100.00%> (+3.16%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f8933...63af785. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant