Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative for models' info and the drop down list #3710

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mtalvi
Copy link
Contributor

@mtalvi mtalvi commented Feb 3, 2025

Description

JIRA - https://issues.redhat.com/browse/NVPE-93
In this PR I replaced the current PF dropdown component with the Select component with Typeahead variant in order to allow the user to start typing in the name of the model to reduce the size of the list.

Before there was no option to type and search in the model's dropdown (NVIDIA NIM):

image

This improves the user experience and will help in searching through the list as you start typing.

How Has This Been Tested?

Tested locally.

Test Impact

When trying to deploy a model using NIM, you should be able to search through the NVIDIA NIM dropdown as you start typing.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Feb 3, 2025
Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

Hi @mtalvi. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@emilys314
Copy link
Contributor

Also there is a formatter error (make sure to run the linter)
https://github.com/opendatahub-io/odh-dashboard/actions/runs/13117343290/job/36595217789?pr=3710#step:4:21

/home/runner/work/odh-dashboard/odh-dashboard/frontend/src/pages/modelServing/screens/projects/NIMServiceModal/NIMModelListSection.tsx 111:36 error Insert prettier/prettier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants