Skip to content

Require conditional rendering of modals

Codecov / codecov/project succeeded Oct 10, 2024 in 0s

84.75% (-0.02%) compared to 25c0564

View this Pull Request on Codecov

84.75% (-0.02%) compared to 25c0564

Details

Codecov Report

Attention: Patch coverage is 81.35593% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.75%. Comparing base (25c0564) to head (dcf71cc).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
.../notebookController/screens/server/SpawnerPage.tsx 9.09% 10 Missing ⚠️
.../components/EditableLabelsDescriptionListGroup.tsx 28.57% 5 Missing ⚠️
...src/pages/projects/notebook/StartNotebookModal.tsx 0.00% 3 Missing ⚠️
...tend/src/pages/projects/pvc/AddNotebookStorage.tsx 66.66% 3 Missing ⚠️
...ebookController/screens/server/StopServerModal.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3308      +/-   ##
==========================================
- Coverage   84.77%   84.75%   -0.02%     
==========================================
  Files        1309     1309              
  Lines       29292    29330      +38     
  Branches     7955     8005      +50     
==========================================
+ Hits        24831    24858      +27     
- Misses       4461     4472      +11
Files with missing lines Coverage Δ
frontend/src/app/DevFeatureFlagsBanner.tsx 100.00% <100.00%> (ø)
...BYONImages/BYONImageModal/ManageBYONImageModal.tsx 92.95% <100.00%> (-0.38%) ⬇️
frontend/src/pages/BYONImages/BYONImagesTable.tsx 93.18% <100.00%> (+0.32%) ⬆️
...end/src/pages/BYONImages/ImportBYONImageButton.tsx 100.00% <100.00%> (ø)
...es/screens/list/AcceleratorProfileEnableToggle.tsx 81.25% <100.00%> (+1.25%) ⬆️
...es/screens/list/DisableAcceleratorProfileModal.tsx 100.00% <ø> (ø)
...age/ManageAcceleratorProfileTolerationsSection.tsx 100.00% <100.00%> (ø)
...reens/manage/tolerations/ManageTolerationModal.tsx 91.66% <ø> (-0.34%) ⬇️
...es/screens/manage/tolerations/TolerationsTable.tsx 100.00% <100.00%> (ø)
...kController/screens/admin/NotebookAdminControl.tsx 100.00% <100.00%> (ø)
... and 18 more

... and 23 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d7822...dcf71cc. Read the comment docs.

View more details on Codecov