Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-12182: Moves the dw installation info to the installation guide #495

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bredamc
Copy link
Contributor

@bredamc bredamc commented Oct 15, 2024

ENG-12182: Moves the dw installation info to the installation guide

@bredamc bredamc self-assigned this Oct 15, 2024
Comment on lines +31 to +39
ifndef::disconnected[]
* You have installed the required distributed workloads components as described in link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}/installing-and-deploying-openshift-ai_install#installing-distributed-workload-components_component-install[Installing the distributed workloads components].
endif::[]

ifdef::disconnected[]
* You have installed the required distributed workloads components as described in link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}_in_a_disconnected_environment/installing-and-deploying-openshift-ai_install#installing-distributed-workload-components_component-install[Installing the distributed workloads components].
endif::[]

endif::[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there is only one SM "Working with distributed workloads" book (there is not a separate one for disconnected), this could be:

  • You have installed the required distributed workloads components as described in link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}/installing-and-deploying-openshift-ai_install#installing-distributed-workload-components_component-install[Installing the distributed workloads components] or link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}_in_a_disconnected_environment/installing-and-deploying-openshift-ai_install#installing-distributed-workload-components_component-install[Installing the distributed workloads components in a disconnected environment].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link has changed, the info is now in the installation guide, not in the DW guide.

Comment on lines +24 to 30
ifndef::disconnected[]
* You have installed the required distributed workloads components as described in link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}/installing-and-deploying-openshift-ai_install#installing-distributed-workload-components_component-install[Installing the distributed workloads components].
endif::[]

ifdef::disconnected[]
* You have installed the required distributed workloads components as described in link:{rhoaidocshome}{default-format-url}/installing_and_uninstalling_{url-productname-short}_in_a_disconnected_environment/installing-and-deploying-openshift-ai_install#installing-distributed-workload-components_component-install[Installing the distributed workloads components].
endif::[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Because there is only one SM "Working with distributed workloads" book (there is not a separate one for disconnected), these links could be combined.

@bredamc bredamc marked this pull request as ready for review October 16, 2024 16:48
In the `spec:components` section, set the `managementState` field correctly for the required components:
+
* If you want to use the CodeFlare framework to tune models, enable the `codeflare`, `kueue`, and `ray` components.
* if you want to use the Kubeflow Training Operator to tune models, enable the `kueue` and `trainingoperator` components.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If

endif::[]
ifdef::upstream[]
For information about configuring resource flavors and quotas, see link:{odhdocshome}/working-with-distributed-workloads/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].
For information about creating a local queue and defining a default local queue, see link:{odhdocshome}/managing_openshift_ai/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link:{odhdocshome}/managing_odh/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].

endif::[]
ifdef::upstream[]
For information about configuring resource flavors and quotas, see link:{odhdocshome}/working-with-distributed-workloads/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].
For information about configuring resource flavors and quotas, see link:{odhdocshome}/managing_openshift_ai/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link:{odhdocshome}/managing_odh/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].

endif::[]
ifdef::upstream[]
For information about configuring resource flavors and quotas, see link:{odhdocshome}/working-with-distributed-workloads/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].
For information about creating a local queue and defining a default local queue, see link:{odhdocshome}/managing_openshift_ai/#configuring-quota-management-for-distributed-workloads_distributed-workloads[Configuring quota management for distributed workloads].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.../managing-odh/...

endif::[]
ifdef::upstream[]
* You can access a data science cluster that is configured to run distributed workloads as described in link:{odhdocshome}/working-with-distributed-workloads/#configuring-distributed-workloads_distributed-workloads[Configuring distributed workloads].
* You can access a data science cluster that is configured to run distributed workloads as described in link:{odhdocshome}/managing-openshift-ai/#managing_distributed_workloads[Managing distributed workloads].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.../managing-odh/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants