update: review comments use const

Signed-off-by: Wen Zhou <[email protected]>

main.go

@@ -204,7 +204,7 @@ func main() { //nolint:funlen,maintidx
 			},
 			// For authentication CR "cluster"
 			&configv1.Authentication{}: {
-				Field: fields.Set{"metadata.name": "cluster"}.AsSelector(),
+				Field: fields.Set{"metadata.name": cluster.ClusterAuthenticationObj}.AsSelector(),
 			},
 			// for prometheus and black-box deployment and ones we owns
 			&appsv1.Deployment{}: {Namespaces: deploymentCache},

pkg/cluster/cluster_config.go

@@ -231,9 +231,9 @@ func getRelease(ctx context.Context, cli client.Client) (Release, error) {
 // This will give indication that Operator should create userGroups or not in the cluster.
 func IsDefaultAuthMethod(ctx context.Context, cli client.Client) (bool, error) {
 	authenticationobj := &configv1.Authentication{}
-	if err := cli.Get(ctx, client.ObjectKey{Name: "cluster", Namespace: ""}, authenticationobj); err != nil {
+	if err := cli.Get(ctx, client.ObjectKey{Name: ClusterAuthenticationObj, Namespace: ""}, authenticationobj); err != nil {
 		if errors.Is(err, &meta.NoKindMatchError{}) { // when CRD is missing, conver error type
-			return false, k8serr.NewNotFound(configv1.Resource("authentications"), "cluster")
+			return false, k8serr.NewNotFound(configv1.Resource("authentications"), ClusterAuthenticationObj)
 		}
 		return false, err
 	}

pkg/cluster/const.go

@@ -12,4 +12,7 @@ const (
 
 	// DefaultNotebooksNamespace defines default namespace for notebooks.
 	DefaultNotebooksNamespace = "rhods-notebooks"
+
+	// Default cluster-scope Authentication CR name.
+	ClusterAuthenticationObj = "cluster"
 )