Skip to content

Commit

Permalink
update: rename variable to make it for broad use.
Browse files Browse the repository at this point in the history
Signed-off-by: Wen Zhou <[email protected]>
  • Loading branch information
zdtsw committed Oct 7, 2024
1 parent 1cb6612 commit a918fed
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Additionally installing `Authorino operator` & `Service Mesh operator` enhances
sourceNamespace: openshift-marketplace
EOF
```
If user would prefer skipping group "odh-admin" to be created by DSCI CR automatically, explicitly set env variable ODH_DISABLE_USERGROUP to "true". example:
If user would prefer skipping group "odh-admin" to be created by DSCI CR automatically, explicitly set env variable ODH_USE_EXTERNAL_AUTH to "true". example:

```console
cat <<EOF | oc create -f -
Expand All @@ -82,7 +82,7 @@ Additionally installing `Authorino operator` & `Service Mesh operator` enhances
sourceNamespace: openshift-marketplace
config:
env:
- name: "ODH_DISABLE_USERGROUP"
- name: "ODH_USE_EXTERNAL_AUTH"
value: "true"
EOF

Expand Down
4 changes: 2 additions & 2 deletions controllers/dscinitialization/dscinitialization_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func (r *DSCInitializationReconciler) Reconcile(ctx context.Context, req ctrl.Re
switch platform {
case cluster.SelfManagedRhods:
// Check if user opted for disabling creating user groups
if os.Getenv("ODH_DISABLE_USERGROUP") == "true" {
if os.Getenv("ODH_USE_EXTERNAL_AUTH") == "true" {
log.Info("DSCI disabled usergroup creation")
} else {
err := r.createUserGroup(ctx, instance, "rhods-admins")
Expand Down Expand Up @@ -239,7 +239,7 @@ func (r *DSCInitializationReconciler) Reconcile(ctx context.Context, req ctrl.Re
}
default:
// Check if user opted for disabling creating user groups
if os.Getenv("ODH_DISABLE_USERGROUP") == "true" {
if os.Getenv("ODH_USE_EXTERNAL_AUTH") == "true" {
log.Info("DSCI disabled usergroup creation")
} else {
err := r.createUserGroup(ctx, instance, "odh-admins")
Expand Down

0 comments on commit a918fed

Please sign in to comment.