Skip to content

Commit

Permalink
api: set manifestUri as deprecated
Browse files Browse the repository at this point in the history
- we do not use this for devFlag in DSCI any more
- it was used when we still have odh-manifests repo
- if use would set devFlags, it should be done in DSC on component base
- keep logic still in code but only set warning on API

Signed-off-by: Wen Zhou <[email protected]>
  • Loading branch information
zdtsw committed Oct 14, 2024
1 parent fa63b4d commit e6b5896
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 3 deletions.
1 change: 1 addition & 0 deletions apis/dscinitialization/v1/dscinitialization_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ type Monitoring struct {
// DevFlags defines list of fields that can be used by developers to test customizations. This is not recommended
// to be used in production environment.
type DevFlags struct {
// ## DEPRECATED ## : ManifestsUri set on DSCI is not maintained.
// Custom manifests uri for odh-manifests
// +optional
ManifestsUri string `json:"manifestsUri,omitempty"`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ spec:
- default
type: string
manifestsUri:
description: Custom manifests uri for odh-manifests
description: '## DEPRECATED ## : ManifestsUri set on DSCI is not
maintained. Custom manifests uri for odh-manifests'
type: string
type: object
monitoring:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ spec:
- default
type: string
manifestsUri:
description: Custom manifests uri for odh-manifests
description: '## DEPRECATED ## : ManifestsUri set on DSCI is not
maintained. Custom manifests uri for odh-manifests'
type: string
type: object
monitoring:
Expand Down
2 changes: 1 addition & 1 deletion docs/api-overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ _Appears in:_

| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `manifestsUri` _string_ | Custom manifests uri for odh-manifests | | |
| `manifestsUri` _string_ | ## DEPRECATED ## : ManifestsUri set on DSCI is not maintained.<br />Custom manifests uri for odh-manifests | | |
| `logmode` _string_ | | production | Enum: [devel development prod production default] <br /> |


Expand Down

0 comments on commit e6b5896

Please sign in to comment.