add: get permission on resources #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- since we already have these resource for create, list, delete etc, no harm to add get on them Signed-off-by: Wen Zhou <[email protected]>
zdtsw
requested review from
jstourac and
VaishnaviHire
and removed request for
cam-garrison
ykaliuta
approved these changes
Jun 7, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit bd9b83c
into
opendatahub-io:incubation
8 checks passed
|
FTR - I raised this issue based on the discussion on slack https://issues.redhat.com/browse/RHOAIENG-8297 - this PR may be fixing it or maybe not. |
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jun 10, 2024
- since we already have these resource for create, list, delete etc, no harm to add get on them Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit bd9b83c)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jun 10, 2024
- since we already have these resource for create, list, delete etc, no harm to add get on them Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit bd9b83c) fix: when delete resource if no CRD in the cluster (opendatahub-io#1044) Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit c040f77) deploy: refactor getResource to return NotFound for both cases (opendatahub-io#1046) Avoid returning (nil, nil), convert error if CRD not present to NotFound and handle them in the caller code. Avoid checking for found == nil but handle only error code. This is more idiomatic and less error prone. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 9651b76) Handle Kserve exception Fix csv
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jun 10, 2024
- since we already have these resource for create, list, delete etc, no harm to add get on them Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit bd9b83c) fix: when delete resource if no CRD in the cluster (opendatahub-io#1044) Signed-off-by: Wen Zhou <[email protected]> (cherry picked from commit c040f77) deploy: refactor getResource to return NotFound for both cases (opendatahub-io#1046) Avoid returning (nil, nil), convert error if CRD not present to NotFound and handle them in the caller code. Avoid checking for found == nil but handle only error code. This is more idiomatic and less error prone. Signed-off-by: Yauheni Kaliuta <[email protected]> (cherry picked from commit 9651b76) Handle Kserve exception Fix csv (cherry picked from commit e5f65bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
related to some offline discussion for the error seen recently:
"buildconfigs.build.openshift.io "rstudio-server-rhel9" is forbidden: User "system:serviceaccount:redhat-ods-operator:redhat-ods-operator-controller-manager" cannot get resource "buildconfigs" in API group "build.openshift.io" in the namespace "redhat-ods-applications"root cause has not been identify, but should be no harm to have all our resource with get permission.
How Has This Been Tested?
Merge criteria: