deploy: refactor getResource to return NotFound for both cases

[ykaliuta]

Avoid returning (nil, nil), convert error if CRD not present to NotFound and handle them in the caller code.

Avoid checking for found == nil but handle only error code.

This is more idiomatic and less error prone.

Description

ref: https://issues.redhat.com/browse/RHOAIENG-8297

How Has This Been Tested?

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[zdtsw]

should this be if found == nil ?

[ykaliuta]

I've exchanged createResource/updateResource to avoid found == nil check

[zdtsw]

sorry, meant to say
if found != nil { // do update }

[ykaliuta]

This will work as well, but if there was no error (err == nil), found is not nil in getResource() so we can stay on checking err only

[ykaliuta]

This could be more clear actually:

func manageResource(ctx context.Context, cli client.Client, obj *unstructured.Unstructured, owner metav1.Object, applicationNamespace, componentName string, enabled bool) error {
	// Return if resource is of Kind: Namespace and Name: odhApplicationsNamespace
	if obj.GetKind() == "Namespace" && obj.GetName() == applicationNamespace {
		return nil
	}

	found, err := getResource(ctx, cli, obj)

	// err == nil means found
	if err == nil {
		if enabled {
			return updateResource(ctx, cli, obj, found, owner, componentName)
		}
		return handleDisabledComponent(ctx, cli, found, componentName)
	}

	if apierrs.IsNotFound(err) {
		// Create resource if it doesn't exist
		return createResource(ctx, cli, obj, owner)
	}

	return err
}

[bartoszmajsak]

LGTM,

Maybe simplify it more as you suggest in https://github.com/opendatahub-io/opendatahub-operator/pull/1046/files#r1632844023

[VaishnaviHire]

Thanks for the PR @ykaliuta

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartoszmajsak, VaishnaviHire, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [VaishnaviHire,zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment