Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add check before calling ApplyParams #1181

Closed
wants to merge 1 commit into from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 15, 2024

Description

How Has This Been Tested?

local build: quay.io/wenzhou/opendatahub-operator:2.16.97-1

  • manually set RELATED_IMAGE_ODH_CODEFLARE_OPERATOR_IMAGE as env to a operator image
  • create DSC and enable codeflare
  • check codeflare podis running with new set image
  • check codeflare's params.env time:
    -rw-r--r--. 1 1001 root 184 Aug 16 13:17 params.env
  • enable another component, to trigger reconcile
  • wait till it is done and check codeflare's params.env time: should be the same since no need re-write
    -rw-r--r--. 1 1001 root 184 Aug 16 13:17 params.env

Screenshot or short clip

hide-me

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Aug 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw force-pushed the chore_97 branch 4 times, most recently from 183330b to 99d8c5f Compare August 16, 2024 13:28
@zdtsw zdtsw marked this pull request as ready for review August 16, 2024 13:29
@zdtsw zdtsw requested review from ykaliuta and VaishnaviHire and removed request for MarianMacik and asanzgom August 16, 2024 15:02
@zdtsw
Copy link
Member Author

zdtsw commented Aug 16, 2024

/test opendatahub-operator-e2e

@ykaliuta
Copy link
Contributor

I would propose another solution for skipping file writes: #1186

@zdtsw zdtsw closed this Aug 16, 2024
- only when any of value(image, env) not present in params.env then call ApplyParams
- avoild frequently disk written to params.env by every reconcile on the components
- remove RELATED_IMAGE_ODH_MODEL_CONTROLLER_IMAGE from modelserving imageParams list
  because it is in the dependent one and never exists in params.env
- fix a wrong path in log for codeflare

Signed-off-by: Wen Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants