chore: update controller recorder events #1212
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- rename from reportError to reportWarning due to EventType is Warning - add reason into function as parameters - Caps messages - do not immediately reconcile DSC if DSCI is missing Signed-off-by: Wen Zhou <[email protected]>
| @@ -148,8 +148,7 @@ func (r *DataScienceClusterReconciler) Reconcile(ctx context.Context, req ctrl.R | |||
| dsciInstances := &dsciv1.DSCInitializationList{} | |||
| err = r.Client.List(ctx, dsciInstances) | |||
| if err != nil { | |||
| r.Log.Error(err, "Failed to retrieve DSCInitialization resource.", "DSCInitialization Request.Name", req.Name) | |||
| r.Recorder.Eventf(instance, corev1.EventTypeWarning, "DSCInitializationReconcileError", "Failed to retrieve DSCInitialization instance") | |||
| r.reportWarning(err, instance, "DSCInitializationReconcileError", "Failed to retrieve DSCInitialization resource") | |||
There was a problem hiding this comment.
If it's warning then I think, we should also change reason value DSCInitializationReconcileWarning instead DSCInitializationReconcileError
wdyt ?
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria