-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: remove two SA which does not seem valid #1254
base: incubation
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -107,9 +107,7 @@ func (m *ModelMeshServing) ReconcileComponent(ctx context.Context, | |||
|
|||
if err := cluster.UpdatePodSecurityRolebinding(ctx, cli, dscispec.ApplicationsNamespace, | |||
"modelmesh", | |||
"modelmesh-controller", | |||
"odh-prometheus-operator", | |||
"prometheus-custom"); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that was added for user workload monitoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be, in odh 2.0.0 alread have these
err := common.UpdatePodSecurityRolebinding(cli, []string{"modelmesh", "modelmesh-controller", "odh-model-controller", "odh-prometheus-operator", "prometheus-custom"}, namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VedantMahabaleshwarkar if you know this ^?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine to remove odh-prometheus-operator
and prometheus-custom
IIRC. But it's been a while, if there is a way to ensure the SRE stack (for managed RHOAI) is working for modelmesh alerts with this change then it should be fine. I'm 90% certain these aren't needed for the SRE stack but it would be good to get that confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could do a downstream build and let QE test on a managed cluster, see how it goes
Signed-off-by: Wen Zhou <[email protected]>
Description
https://issues.redhat.com/browse/RHOAIENG-13411
How Has This Been Tested?
Screenshot or short clip
Merge criteria