Modify Unit Tests GitHub Actions workflow to get code coverage test reports #1279

asanzgom · 2024-10-07T10:05:51Z

Modify Unit Tests GitHub Actions workflow to implement codecov in order to get code coverage test reports

asanzgom · 2024-10-07T10:58:45Z

@VaishnaviHire @zdtsw @ykaliuta @StevenTobin @csams @biswassri Can you please add yourselves as reviewers? I cannot

zdtsw · 2024-10-07T10:40:23Z

.github/workflows/codecov.yml

+      - name: Upload results to Codecov
+        uses: codecov/codecov-action@v4
+        with:
+          token: ${{ secrets.CODECOV_TOKEN }}


do we have account to update and use codecov.io?

no need explicity set files: coverage.txt ?

for that part we will need to establish a token with an account and help and from a repository owner, in the meanwhile this is just the workflow that will make use of it

zdtsw · 2024-10-07T10:50:30Z

.github/workflows/codecov.yml

+        run: go mod download
+
+      - name: Run tests
+        run: go test -coverprofile=coverage.txt


what will be in coverage.txt?

coverpofile ensures that we collect coverage, and the metrics will be it output to the text file the results

maybe i did not make myself clear in that comments.
have you tested this at least locally to see it worked before created this PR or if any runs from GHA can be backed for this change.

Yes @zdtsw , I did implement codecov and get a test coverage report on a sample repo:

.github/workflows/codecov.yml

zdtsw · 2024-10-07T11:03:52Z

but all in all, why not hook this in to unit-test but create one workflow for it?

asanzgom · 2024-10-07T11:22:39Z

but all in all, why not hook this in to unit-test but create one workflow for it?

I can do that if you all agree

ajaypratap003 · 2024-10-08T06:53:04Z

but all in all, why not hook this in to unit-test but create one workflow for it?

I can do that if you all agree

@asanzgom Yes, I think it would be good to hook with unit-test as code coverage is about unit-testing

.github/workflows/codecov.yml

Co-authored-by: Wen Zhou <[email protected]>

…/opendatahub-operator into asanzgom-codecov-implementation

asanzgom · 2024-10-08T09:19:30Z

but all in all, why not hook this in to unit-test but create one workflow for it?

I can do that if you all agree

@asanzgom Yes, I think it would be good to hook with unit-test as code coverage is about unit-testing

Consolidated into the unit tests workflow

codecov-commenter · 2024-10-08T09:22:25Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

AjayJagan · 2024-10-08T09:50:09Z

lgtm

ajaypratap003

LGTM.
Make sure CODECOV_TOKEN token must be set in repo before merging this PR.

asanzgom · 2024-10-08T10:13:21Z

@ajaypratap003 @AjayJagan LGTM label needs to be added

ajaypratap003

/lgtm

AjayJagan · 2024-10-08T11:11:21Z

/lgtm

biswassri

Lgtm

openshift-ci · 2024-10-08T18:41:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: biswassri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [biswassri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* cluster_config: init cluster variables on startup (#1059) * cluster_config: move type definitions to the beginning of the file Just a bit more clarity Signed-off-by: Yauheni Kaliuta <[email protected]> * cluster_config: init cluster variables on startup Cluster configuration is supposed to be the same during operator pod lifetime. There is no point to detect it on every reconcile cycle keeping in mind that it can causes many api requests. Do the initialization on startup. Keep GetOperatorNamespace() returning error since it defines some logic in the DSCInitialization reconciler. Automatically called init() won't work here due to need to check error of the initialization. Wrap logger into context and use it in the Init() like controller-runtime does [1][2]. Save root context without the logger for mgr.Start since "setup" logger does not fit normal manager's work. Leave GetDomain() as is since it uses OpenshiftIngress configuration which is created when DSCInitialization instantiated. Log cluster configuration on success from Init, so remove platform logging from main. [1] https://github.com/kubernetes-sigs/controller-runtime/blob/38546806f2faf5973e3321a7bd5bb3afdbb5767d/pkg/internal/controller/controller.go#L297 [2] https://github.com/kubernetes-sigs/controller-runtime/blob/38546806f2faf5973e3321a7bd5bb3afdbb5767d/pkg/internal/controller/controller.go#L111 Signed-off-by: Yauheni Kaliuta <[email protected]> * cluster: do not return error from GetRelease GetRelease return values are defined at startup, the error checked in main, so no point to return error anymore. Signed-off-by: Yauheni Kaliuta <[email protected]> --------- Signed-off-by: Yauheni Kaliuta <[email protected]> * components: move params.env image updating to Init stage (#1191) * components, main: add Component Init method Add Init() method to the Component interface and call it from main on startup. Will be used to move startup-time code from ReconcileComponent (like adjusting params.env). Signed-off-by: Yauheni Kaliuta <[email protected]> * components: move params.env image updating to Init stage Jira: https://issues.redhat.com/browse/RHOAIENG-11592 Image names in environment are not supposed to be changed during runtime of the operator, so it makes sense to update them only on startup. If manifests are overriden by DevFlags, the DevFlags' version will be used. The change is straight forward for most of the components where only images are updated and params.env is located in the kustomize root directory, but some components (dashboard, ray, codeflare, modelregistry) also update some extra parameters. For them image part only is moved to Init since other updates require runtime DSCI information. The patch also changes logic for ray, codeflare, and modelregistry in this regard to update non-image parameters regardless of DevFlags like it was changed in dashboard recently. The DevFlags functionality brings some concerns: - For most components the code is written such a way that as soon as DevFlags supplied the global path variables are changed and never reverted back to the defaults. For some (dashboard, trustyai) there is (still global) OverridePath/entryPath pair and manifests reverted to the default, BUT there is no logic of transition. - codeflare: when manifests are overridden namespace param is updated in the hardcoded (stock) path; This logic is preserved. Signed-off-by: Yauheni Kaliuta <[email protected]> --------- Signed-off-by: Yauheni Kaliuta <[email protected]> * update: remove webhook service from bundle (#1275) - we do not need it in bundle, CSV auto generate one during installation - if we install operator via OLM, webhook service still get used from config/webhook/service.yaml Signed-off-by: Wen Zhou <[email protected]> * update: add validation on application and monitoring namespace in DSCI (#1263) Signed-off-by: Wen Zhou <[email protected]> * logger: add zap command line switches (#1280) Allow to tune preconfigured by --log-mode zap backend with standard zap command line switches from controller-runtime (zap-devel, zap-encoder, zap-log-level, zap-stacktrace-level, zap-time-encoding)[1]. This brings flexibility in logger setup for development environments first of all. The patch does not change default logger setup and does not change DSCI override functionality. [1] https://sdk.operatorframework.io/docs/building-operators/golang/references/logging Signed-off-by: Yauheni Kaliuta <[email protected]> * Modify Unit Tests GitHub Actions workflow to get code coverage test reports (#1279) * Create codecov.yml * Added to run test coverage also on PRs * Removing trailing ] * Update .github/workflows/codecov.yml Co-authored-by: Wen Zhou <[email protected]> * Removed go mod install dependency * Consolidated codecov workflow into unit tests workflow --------- Co-authored-by: Wen Zhou <[email protected]> * webhook: move initialization inside of the module (#1284) Add webhook.Init() function and hide webhook setup inside of the module. It will make it possible to replace Init with a NOP (no operation) with conditional compilation for no-webhook build. Signed-off-by: Yauheni Kaliuta <[email protected]> * feat: pass platform from env variable or fall back to use old logic (#1252) * feat: pass platform from env variables or fall back to use old logic - introduce new env var ODH_PLATFORM_TYPE, value set during build time - if value not match, fall back to detect managed then self-managed - introduce new env var OPERATOR_RELEASE_VERSION, value also set during build time - if value is empty, fall back to use old way from CSV to read version or use 0.0.0 - add support from makefile - use envstubst to replace version Signed-off-by: Wen Zhou <[email protected]> * update: remove release version in the change Signed-off-by: Wen Zhou <[email protected]> --------- Signed-off-by: Wen Zhou <[email protected]> * fix: update release version in DSCI and DSC .status for upgrade case (#1287) - DSCI: if current version is not matching, update it - DSC: in both reconcile pass and fail case, update it Signed-off-by: Wen Zhou <[email protected]> * Update version to 2.19.0 (#1291) Co-authored-by: VaishnaviHire <[email protected]> --------- Signed-off-by: Yauheni Kaliuta <[email protected]> Signed-off-by: Wen Zhou <[email protected]> Co-authored-by: Yauheni Kaliuta <[email protected]> Co-authored-by: Wen Zhou <[email protected]> Co-authored-by: Adrián Sanz Gómiz <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: VaishnaviHire <[email protected]>

Create codecov.yml

6fb5660

openshift-ci bot requested review from ajaypratap003 and jackdelahunt October 7, 2024 10:05

zdtsw reviewed Oct 7, 2024

View reviewed changes

zdtsw requested a review from biswassri October 7, 2024 11:04

Merge branch 'incubation' into asanzgom-codecov-implementation

8061e9d

ajaypratap003 reviewed Oct 8, 2024

View reviewed changes

.github/workflows/codecov.yml Outdated Show resolved Hide resolved

asanzgom and others added 3 commits October 8, 2024 10:04

Added to run test coverage also on PRs

6481c17

Removing trailing ]

cf24296

Update .github/workflows/codecov.yml

5b06561

Co-authored-by: Wen Zhou <[email protected]>

asanzgom requested review from zdtsw and ajaypratap003 October 8, 2024 08:06

asanzgom added 3 commits October 8, 2024 10:14

Removed go mod install dependency

b128a07

Merge branch 'asanzgom-codecov-implementation' of github.com:asanzgom…

5b5e8d6

…/opendatahub-operator into asanzgom-codecov-implementation

Consolidated codecov workflow into unit tests workflow

9a867a1

asanzgom changed the title ~~Create codecov.yml GitHub Actions workflow to get code coverage test reports~~ Modify Unit Tests GitHub Actions workflow to get code coverage test reports Oct 8, 2024

ajaypratap003 reviewed Oct 8, 2024

View reviewed changes

openshift-ci bot assigned AjayJagan Oct 8, 2024

openshift-ci bot added the lgtm label Oct 8, 2024

biswassri approved these changes Oct 8, 2024

View reviewed changes

openshift-ci bot assigned biswassri Oct 8, 2024

openshift-ci bot added the approved label Oct 8, 2024

openshift-merge-bot bot merged commit 6134496 into opendatahub-io:incubation Oct 8, 2024
4 checks passed

asanzgom deleted the asanzgom-codecov-implementation branch October 9, 2024 11:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Modify Unit Tests GitHub Actions workflow to get code coverage test reports #1279

Modify Unit Tests GitHub Actions workflow to get code coverage test reports #1279

asanzgom commented Oct 7, 2024 •

edited

Loading

asanzgom commented Oct 7, 2024

zdtsw Oct 7, 2024

zdtsw Oct 7, 2024

asanzgom Oct 7, 2024

zdtsw Oct 7, 2024

asanzgom Oct 7, 2024

zdtsw Oct 7, 2024

asanzgom Oct 7, 2024 •

edited

Loading

zdtsw commented Oct 7, 2024

asanzgom commented Oct 7, 2024

ajaypratap003 commented Oct 8, 2024

asanzgom commented Oct 8, 2024

codecov-commenter commented Oct 8, 2024

AjayJagan commented Oct 8, 2024

ajaypratap003 left a comment

asanzgom commented Oct 8, 2024

ajaypratap003 left a comment •

edited

Loading

AjayJagan commented Oct 8, 2024

biswassri left a comment

openshift-ci bot commented Oct 8, 2024

Modify Unit Tests GitHub Actions workflow to get code coverage test reports #1279

Modify Unit Tests GitHub Actions workflow to get code coverage test reports #1279

Conversation

asanzgom commented Oct 7, 2024 • edited Loading

asanzgom commented Oct 7, 2024

zdtsw Oct 7, 2024

Choose a reason for hiding this comment

zdtsw Oct 7, 2024

Choose a reason for hiding this comment

asanzgom Oct 7, 2024

Choose a reason for hiding this comment

zdtsw Oct 7, 2024

Choose a reason for hiding this comment

asanzgom Oct 7, 2024

Choose a reason for hiding this comment

zdtsw Oct 7, 2024

Choose a reason for hiding this comment

asanzgom Oct 7, 2024 • edited Loading

Choose a reason for hiding this comment

zdtsw commented Oct 7, 2024

asanzgom commented Oct 7, 2024

ajaypratap003 commented Oct 8, 2024

asanzgom commented Oct 8, 2024

codecov-commenter commented Oct 8, 2024

Welcome to Codecov 🎉

AjayJagan commented Oct 8, 2024

ajaypratap003 left a comment

Choose a reason for hiding this comment

asanzgom commented Oct 8, 2024

ajaypratap003 left a comment • edited Loading

Choose a reason for hiding this comment

AjayJagan commented Oct 8, 2024

biswassri left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 8, 2024

asanzgom commented Oct 7, 2024 •

edited

Loading

asanzgom Oct 7, 2024 •

edited

Loading

ajaypratap003 left a comment •

edited

Loading