Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default managementState as Removed to allow new components to show up in old DSCs, fixes RHOAIENG-14194 #1293

Draft
wants to merge 1 commit into
base: incubation
Choose a base branch
from
+13 −1
Draft

fix: add default managementState as Removed to allow new components to show up in old DSCs, fixes RHOAIENG-14194 #1293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/component.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ type Component struct {
// or if it is installed, the operator will try to remove it
//
// +kubebuilder:validation:Enum=Managed;Removed
// +kubebuilder:default=Removed
ManagementState operatorv1.ManagementState `json:"managementState,omitempty"`
// Add any other common fields across components below

Expand Down
11 changes: 11 additions & 0 deletions config/crd/bases/datasciencecluster.opendatahub.io_datascienceclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -125,6 +126,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -173,6 +175,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -232,6 +235,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -336,6 +340,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -384,6 +389,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -430,6 +436,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -490,6 +497,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -536,6 +544,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -582,6 +591,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down Expand Up @@ -628,6 +638,7 @@ spec:
type: array
type: object
managementState:
default: Removed
description: |-
Set to one of the following values:

Expand Down
2 changes: 1 addition & 1 deletion docs/api-overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ _Appears in:_

| Field | Description | Default | Validation |
| --- | --- | --- | --- |
| `managementState` _[ManagementState](#managementstate)_ | Set to one of the following values:<br /><br />- "Managed" : the operator is actively managing the component and trying to keep it active.<br /> It will only upgrade the component if it is safe to do so<br /><br />- "Removed" : the operator is actively managing the component and will not install it,<br /> or if it is installed, the operator will try to remove it | | Enum: [Managed Removed] <br /> |
| `managementState` _[ManagementState](#managementstate)_ | Set to one of the following values:<br /><br />- "Managed" : the operator is actively managing the component and trying to keep it active.<br /> It will only upgrade the component if it is safe to do so<br /><br />- "Removed" : the operator is actively managing the component and will not install it,<br /> or if it is installed, the operator will try to remove it | Removed | Enum: [Managed Removed] <br /> |
| `devFlags` _[DevFlags](#devflags)_ | Add developer fields | | |


Expand Down