Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use client.OjectKeyFromObject in client.Get() and add k8serr as alias #1301

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 14, 2024

Description

  • use k8serr as alias to match other places in the code
  • use OjectKeyFromObject with object already set for .Get()

local build: 'quay.io/wenzhou/opendatahub-operator:2.19.1014-1'

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@lburgazzoli
Copy link
Contributor

Further improvements on the logic can be made on a separate PR, so this LGTM
@ykaliuta WDYT ?

@ykaliuta
Copy link
Contributor

Further improvements on the logic can be made on a separate PR, so this LGTM @ykaliuta WDYT ?

agree

Copy link

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw merged commit 2708e54 into opendatahub-io:incubation Oct 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants