Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use label selector to pick namespace #1427

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Dec 7, 2024

cherry-pick #1370 + more kinds

  • for clean installation:
    • if user keep using default pre-defined namespace: same as before
    • if user want to use a different namespace: they will need to create project themselves, and add label "opendatahub.io/watched-namespace": "true" then install ODH operator and create DSCI by fill in these namespaces or install RHOAI and delete auto created DSCI and create DSCI by fill in these namespaces
  • for upgrade: operator only use selector to get namespace this can bypass hardcoded namespace limitation

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Dec 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zdtsw. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw requested review from lburgazzoli and removed request for Sara4994 and jackdelahunt December 7, 2024 09:27
@zdtsw
Copy link
Member Author

zdtsw commented Dec 7, 2024

dont think if it is needed, but open it in case we wanna have it for 407 phase 1

@lburgazzoli
Copy link
Contributor

can we move this as draft, I think discussion at this stage is very much ongoing so better to be sure it matches the expectations

@zdtsw zdtsw marked this pull request as draft December 7, 2024 09:36
@zdtsw
Copy link
Member Author

zdtsw commented Dec 7, 2024

can we move this as draft, I think discussion at this stage is very much ongoing so better to be sure it matches the expectations

sure, i leave it to the team to discuss if it is needed.

- for clean installation:
  - if user keep using default pre-defined namespace: same as before
  - if user want to use a different namespace: they will need to create project
    themselves, and add label "opendatahub.io/watched-namespace": "true"
    then install ODH operator and create DSCI by fill in these namespaces
    or install RHOAI and delete auto created DSCI and create DSCI by fill in these namespaces
- for upgrade: operator only use selector to get namespace
  this can bypass hardcoded namespace limitation
- add more resource kinds into cache due to change use component CR with owns and watches

Signed-off-by: Wen Zhou <[email protected]>
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6636abb). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage        ?   25.73%           
=======================================
  Files           ?       67           
  Lines           ?     5491           
  Branches        ?        0           
=======================================
  Hits            ?     1413           
  Misses          ?     3905           
  Partials        ?      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants