-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use label selector to pick namespace #1427
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dont think if it is needed, but open it in case we wanna have it for 407 phase 1 |
can we move this as draft, I think discussion at this stage is very much ongoing so better to be sure it matches the expectations |
sure, i leave it to the team to discuss if it is needed. |
- for clean installation: - if user keep using default pre-defined namespace: same as before - if user want to use a different namespace: they will need to create project themselves, and add label "opendatahub.io/watched-namespace": "true" then install ODH operator and create DSCI by fill in these namespaces or install RHOAI and delete auto created DSCI and create DSCI by fill in these namespaces - for upgrade: operator only use selector to get namespace this can bypass hardcoded namespace limitation - add more resource kinds into cache due to change use component CR with owns and watches Signed-off-by: Wen Zhou <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
=======================================
Coverage ? 25.73%
=======================================
Files ? 67
Lines ? 5491
Branches ? 0
=======================================
Hits ? 1413
Misses ? 3905
Partials ? 173 ☔ View full report in Codecov by Sentry. |
cherry-pick #1370 + more kinds
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria