Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter order in resolveTargetPath to ensure manifest overwrite #1462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ugiordan
Copy link
Contributor

@ugiordan ugiordan commented Dec 19, 2024

Description

This PR fixes an issue in the DownloadManifests function where the parameters componentName and contextDir were passed in the wrong order to the resolveTargetPath function.

The incorrect order caused downloaded component manifests to be ignored, preventing them from overwriting existing local manifest files as intended.

Fixing https://issues.redhat.com/browse/RHOAIENG-17146

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from CFSNM and etirelli December 19, 2024 11:43
Copy link

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ugiordan. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ugiordan ugiordan changed the title Fixing parameter order in resolveTargetPath call to ensure proper com… Fix parameter order in resolveTargetPath to ensure manifest overwrite Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@8e1b8f5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/deploy/deploy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1462   +/-   ##
=======================================
  Coverage        ?   19.12%           
=======================================
  Files           ?      158           
  Lines           ?    10355           
  Branches        ?        0           
=======================================
  Hits            ?     1980           
  Misses          ?     8151           
  Partials        ?      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant