Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrustyAI] Add test to verify scheduling of drift metrics #103

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

adolfo-ab
Copy link
Contributor

This PR adds a test to verify the scheduling of TrustyAI drift metrics, and improves related util functions

Description

  • Adds a test to verify TrustyAI drift metric scheduling
  • Improve related util functions (send inference requests, check that TrustyAI registers them)

How Has This Been Tested?

Running the test against a PSI cluster

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/lgtm', '/verified', '/wip', '/hold'}

tests/trustyai/drift/utils.py Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
tests/trustyai/drift/utils.py Outdated Show resolved Hide resolved
@adolfo-ab adolfo-ab force-pushed the trustyai-drift-schedule branch from 6360b5e to 149f008 Compare January 27, 2025 14:56
@adolfo-ab
Copy link
Contributor Author

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Jan 27, 2025
@rnetser
Copy link
Collaborator

rnetser commented Jan 27, 2025

/lgtm

@rnetser rnetser merged commit 76b9926 into opendatahub-io:main Jan 27, 2025
4 checks passed
mwaykole pushed a commit to mwaykole/opendatahub-tests that referenced this pull request Jan 29, 2025
…b-io#103)

* [TrustyAI] Add test to verify scheduling of drift metrics

This PR adds a test to verify the scheduling of TrustyAI drift metrics, and improves related util functions

* Create common function to validate TrustyAI requests

* Replace tenacity retry with TimeoutWatch retry decorator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xxl Verified Verified pr in Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants