Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[model server] Refactor fixtures to re-use code #88

Merged
merged 25 commits into from
Jan 8, 2025

Conversation

rnetser
Copy link
Collaborator

@rnetser rnetser commented Jan 7, 2025

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

github-actions bot commented Jan 7, 2025

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/hold', '/verified', '/lgtm', '/wip'}

@rnetser
Copy link
Collaborator Author

rnetser commented Jan 7, 2025

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Jan 7, 2025
@rnetser rnetser merged commit c7bd165 into opendatahub-io:main Jan 8, 2025
4 checks passed
@rnetser rnetser deleted the refactor-fixtures branch January 8, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xl Verified Verified pr in Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants