Use data connection secret to store s3 info, use storage-initializer mage from the cluster
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/hold', '/verified', '/lgtm'} |
|
/verified |
rnetser
changed the title
data connection secret to store s3 informationdata connection secret to store s3 info, use storage-initializer mage from the cluster
lugi0
reviewed
Jan 20, 2025
github-actions
bot
added
size/xl
and removed
size/l
Verified
|
/verified |
lugi0
previously approved these changes
Jan 20, 2025
lugi0
approved these changes
Jan 20, 2025
|
/verified |
mwaykole
approved these changes
Jan 20, 2025
mwaykole
pushed a commit
to mwaykole/opendatahub-tests
that referenced
this pull request
Jan 29, 2025
…r mage from the cluster (opendatahub-io#97) * Create size-labeler.yml * Delete .github/workflows/size-labeler.yml * get storage-in from cluster * move to json-based secrets * update storage path * fix labels * remove unused ci_s3_storage_uri * refactor annottions class in constants
mwaykole
pushed a commit
to mwaykole/opendatahub-tests
that referenced
this pull request
Jan 29, 2025
…r mage from the cluster (opendatahub-io#97) * Create size-labeler.yml * Delete .github/workflows/size-labeler.yml * get storage-in from cluster * move to json-based secrets * update storage path * fix labels * remove unused ci_s3_storage_uri * refactor annottions class in constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using
data connectionsecrets, storage-config secret will be auto-generated by odh-model-controller and this is currently the recommended way (and the one used by the dashboard) to create a connection secret