generated from RedHatQE/python-template-repository
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixture to set managementState for components #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lugi0 <[email protected]>
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/verified', '/lgtm', '/hold'} |
rnetser
requested changes
Jan 23, 2025
Signed-off-by: lugi0 <[email protected]>
rnetser
reviewed
Jan 23, 2025
Signed-off-by: lugi0 <[email protected]>
rnetser
approved these changes
Jan 24, 2025
mwaykole
approved these changes
Jan 24, 2025
mwaykole
pushed a commit
to mwaykole/opendatahub-tests
that referenced
this pull request
Jan 29, 2025
* Add fixture to set managementState for components Signed-off-by: lugi0 <[email protected]> * Address PR comments Signed-off-by: lugi0 <[email protected]> * return dsc instead of yield Signed-off-by: lugi0 <[email protected]> --------- Signed-off-by: lugi0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two fixtures, one to get the DSC resource in the cluster which is run in a session scope and the other to patch the managementState of a given component to the desired state with ResourceEditor, which will revert the change after the fixture call is done.
For now it has been set with scope "module", assuming that a given component needs to be modified for the whole test module.
There is an accompanying helper function that gets the current state of a component, to avoid a useless patch if the desired state is the one already set in the DSC.
Small improvement to the "test_model_registry_creation" test module to enable the MR component if currently set to Removed (default behaviour while the component is in Tech Preview)
How Has This Been Tested?
Tested running the model registry creation test with the component state set to both Managed and Removed beforehand
Merge criteria: