Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some components are enabled by default. #192

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Some components are enabled by default. #192

merged 1 commit into from
Sep 22, 2023

Conversation

adelton
Copy link
Contributor

@adelton adelton commented Sep 15, 2023 •
edited
Loading

Description

Tweak the guidance a bit to match the 2.1.0 behaviour when some components are selected by default.

Fixes #186

How Has This Been Tested?

No testing was done.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@adelton adelton mentioned this pull request Sep 15, 2023
Closed
VaishnaviHire
VaishnaviHire approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@VaishnaviHire VaishnaviHire merged commit d019376 into opendatahub-io:main Sep 22, 2023
@adelton adelton deleted the issue-186 branch September 25, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

By default, it will not enable any component
2 participants
@adelton @VaishnaviHire