Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an alert to point users to the correct relese notes. #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AjayJagan
Copy link

Provide a message to users about the latest release notes.

Description

After some discussion with the team, it seems that the information about a release should have a singe source of truth and that being the https://github.com/opendatahub-io/opendatahub-operator/releases/latest.
So the idea is to provide a useful notice to the users so that they can navigate to the correct one.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@AjayJagan
Copy link
Author

@VaishnaviHire @zdtsw ^^
Please let me know your thoughts on this

@@ -41,6 +41,11 @@ const DocsPageTemplate = ({
isWidthLimited
padding={{ default: "padding" }}
>
<Alert variant="info" title="Important Notice" isInline className="pf-u-mb-xl">
<p>
Please note that the latest information about release notes has been moved <a href="https://github.com/opendatahub-io/opendatahub-operator/releases/latest" target="_blank" rel="noopener noreferrer">here</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something more like if want to checkout previous v2 releases, go https://github.com/opendatahub-io/opendatahub-operator/releases and use "find release" to search for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep I could do that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@zdtsw
Copy link
Member

zdtsw commented Oct 10, 2024

i am fine with the change, just needs another eyes on it

@AjayJagan AjayJagan marked this pull request as ready for review October 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants