by default analyzePullRequests should be false (#731) #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* by default analyzePullRequests should be false (cherry picked from commit 0a8112c)
|
hey @s2oBCN , I think the doc needs to be updates as well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this isssue #663
Instead of change all the 'quickstarters' is better to change the default behaviour.
Detailed explanation:
SonarQu can generate a scan for a branch or a scan for a PR.
We can only ask SonarQu a report of a branch. See Cannot generate report from Pull Request cnescatlab/sonar-cnes-report#159
As we are always asking for the report of the branch, not for a report of a PR. Then, by default, we should generate a report for the branch, not for the PR.