Conversation
added 19 commits
May 14, 2025 21:25
…veyForm component
refactor: update Task entity schema from 'public' to 'processing'
…bsolete backend tests workflow
… with detailed Javadoc comments
…mports in models.py
…move obsolete pipeline files
… CI configuration
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines CI workflows, adds processing service tests, updates DB schema handling across services, and enriches documentation with CI instructions.
- Consolidates GitHub Actions into
formulaai-ci.yml, adds processing service tests, and removes outdated workflows. - Adjusts database migrations and JPA mappings for survey and processing schemas.
- Adds Javadoc comments in model/controller classes and updates README files with CI details.
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| survey/src/main/resources/db/migration/V1__initial_dbstructure.sql | Removes hardcoded survey seed insertion |
| survey/src/main/java/com/formulai/survey/model/Task.java | Changes Task table schema to processing |
| processing/app/models.py | Enhances status field to use PgEnum and inline sa_column |
| processing/app/database.py | Filters owned tables by schema and adds survey schema creation |
| processing/app/tests/test_task.py | Deletes test_get_task_status without replacement |
| frontend/src/components/Form/SurveyForm.tsx | Refactors prop destructuring, types, effect dependencies, and cleans commented code |
| .github/workflows/formulaai-ci.yml | Introduces unified CI workflow with filter-based job execution |
| survey/README.md, processing/README.md, frontend/README.md, README.md | Adds CI sections detailing checks per service |
Comments suppressed due to low confidence (5)
processing/app/tests/test_task.py:15
- The
test_get_task_statuswas removed, leaving the status endpoint untested. Add or revise tests to cover the/tasks/{id}/statusendpoint to maintain coverage.
def test_get_task_status():
frontend/src/components/Form/SurveyForm.tsx:13
- [nitpick] Using a hyphenated prop name (
'form-id') deviates from common React conventions and complicates destructuring—consider renaming toformIdor using camelCase at the component API boundary.
export const SurveyForm = ({ 'form-id': formId }: SurveyFormProps) => {
frontend/src/components/Form/SurveyForm.tsx:80
- [nitpick] There’s leftover commented code at the end of the file. Remove dead code to keep the component clean.
// const LeftAlignedFormLabel = styled(FormLabel)({
survey/src/main/java/com/formulai/survey/model/Task.java:20
- The survey service’s
Taskentity is mapped to theprocessingschema but the migration script for this service doesn’t create aprocessingschema ortasktable. Either update the migration to create and seed theprocessing.tasktable or revert the schema to match existing DB migrations.
@Table(name = "task",schema = "processing")
processing/app/models.py:12
- The
Columnclass is used in thestatusfield definition but not imported. Addfrom sqlalchemy import Columnto avoid a runtimeNameError.
from sqlalchemy import Enum as PgEnum
survey/src/main/java/com/formulai/survey/controllers/SurveyController.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rvice tests