Skip to content

chore: update e2e workflow to simplify commands and add processing se…#86

Merged
rkorszun merged 20 commits intodevelopfrom
57-devops-configure-ci-pipeline-before-pr
May 15, 2025
Merged

chore: update e2e workflow to simplify commands and add processing se…#86
rkorszun merged 20 commits intodevelopfrom
57-devops-configure-ci-pipeline-before-pr

Conversation

@rkorszun
Copy link
Copy Markdown
Collaborator

…rvice tests

@rkorszun rkorszun linked an issue May 14, 2025 that may be closed by this pull request
Rafał Korszuń added 19 commits May 14, 2025 21:25
refactor: update Task entity schema from 'public' to 'processing'
@rkorszun rkorszun requested a review from Copilot May 15, 2025 22:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR streamlines CI workflows, adds processing service tests, updates DB schema handling across services, and enriches documentation with CI instructions.

  • Consolidates GitHub Actions into formulaai-ci.yml, adds processing service tests, and removes outdated workflows.
  • Adjusts database migrations and JPA mappings for survey and processing schemas.
  • Adds Javadoc comments in model/controller classes and updates README files with CI details.

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
survey/src/main/resources/db/migration/V1__initial_dbstructure.sql Removes hardcoded survey seed insertion
survey/src/main/java/com/formulai/survey/model/Task.java Changes Task table schema to processing
processing/app/models.py Enhances status field to use PgEnum and inline sa_column
processing/app/database.py Filters owned tables by schema and adds survey schema creation
processing/app/tests/test_task.py Deletes test_get_task_status without replacement
frontend/src/components/Form/SurveyForm.tsx Refactors prop destructuring, types, effect dependencies, and cleans commented code
.github/workflows/formulaai-ci.yml Introduces unified CI workflow with filter-based job execution
survey/README.md, processing/README.md, frontend/README.md, README.md Adds CI sections detailing checks per service
Comments suppressed due to low confidence (5)

processing/app/tests/test_task.py:15

  • The test_get_task_status was removed, leaving the status endpoint untested. Add or revise tests to cover the /tasks/{id}/status endpoint to maintain coverage.
def test_get_task_status():

frontend/src/components/Form/SurveyForm.tsx:13

  • [nitpick] Using a hyphenated prop name ('form-id') deviates from common React conventions and complicates destructuring—consider renaming to formId or using camelCase at the component API boundary.
export const SurveyForm = ({ 'form-id': formId }: SurveyFormProps) => {

frontend/src/components/Form/SurveyForm.tsx:80

  • [nitpick] There’s leftover commented code at the end of the file. Remove dead code to keep the component clean.
// const LeftAlignedFormLabel = styled(FormLabel)({

survey/src/main/java/com/formulai/survey/model/Task.java:20

  • The survey service’s Task entity is mapped to the processing schema but the migration script for this service doesn’t create a processing schema or task table. Either update the migration to create and seed the processing.task table or revert the schema to match existing DB migrations.
@Table(name = "task",schema = "processing")

processing/app/models.py:12

  • The Column class is used in the status field definition but not imported. Add from sqlalchemy import Column to avoid a runtime NameError.
from sqlalchemy import Enum as PgEnum

@rkorszun rkorszun merged commit 2939cc1 into develop May 15, 2025
5 checks passed
@rkorszun rkorszun deleted the 57-devops-configure-ci-pipeline-before-pr branch May 15, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DevOps] configure CI pipeline before PR

2 participants