-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(xrk): add new env named Flozen Lake and DQN algorithm. #779
Conversation
|
||
policy = dict( | ||
cuda=True, | ||
load_path='cartpole_dqn_seed0/ckpt/ckpt_best.pth.tar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused fields or update its values
end=0.1, | ||
decay=10000, | ||
), | ||
replay_buffer=dict(replay_buffer_size=128, ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why use such a small buffer
|
||
@ENV_REGISTRY.register('frozen_lake') | ||
class FrozenLakeEnv(BaseEnv): | ||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why comment this method
|
||
@staticmethod | ||
def frames_to_gif(self,frames, gif_path, duration=0.1): | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add English comments and Python typing lint
env.seed(314,dynamic_seed=False) | ||
assert env._seed == 314 | ||
obs = env.reset() | ||
print(obs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some assertions about the results of env.step
Description
Add adaptation to gymnasium environment and give examples based on DQN algorithm
Related Issue
TODO
Need to be compatible with the latest pipeline
Check List