feature(xjy): add support for selectable encoder/decoder options for jericho's world model #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puyuan1996
changed the title
puyuan1996
requested changes
Jul 29, 2025
puyuan1996
reviewed
Aug 24, 2025
puyuan1996
reviewed
Aug 24, 2025
puyuan1996
reviewed
Aug 24, 2025
| collector_env_num: int = 4 # Number of collector environments | ||
| n_episode = int(collector_env_num*gpu_num) | ||
| batch_size = int(8*gpu_num) | ||
| batch_size = int(1*gpu_num) |
There was a problem hiding this comment.
jericho目前的实验都是用的这个config跑的吗？segment config那个有测试过收敛性吗
There was a problem hiding this comment.
单任务的没有试过，但是之前多任务的跑segment不如当前这种
puyuan1996
reviewed
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It supports using option=["qwen", "legacy"] to select qwen as the encoder/decoder or the original bge-encoder/t5-decoder