Readiness probe changes #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
niladrih
force-pushed
the
healthz-test
branch
2 times, most recently
from
39feb24 to
f2a5141
Compare
tryBuild succeeded: |
tiagolobocastro
approved these changes
Dec 7, 2024
tiagolobocastro
approved these changes
Dec 7, 2024
niladrih
force-pushed
the
healthz-test
branch
from
f2a5141 to
8013e2d
Compare
niladrih
changed the title
|
bors try |
tryBuild succeeded: |
niladrih
force-pushed
the
healthz-test
branch
from
8013e2d to
8245991
Compare
Signed-off-by: Niladri Halder <[email protected]>
The readiness check API depends on the agent-core service's Node gRPC endpoint. The current RwLock lets multiple tokio threads probe the agent-core. This is not ideal. This change makes the get operation atomic, so that agent-core state cache updates could be performed by only a single thread, and the updated cache should feed the next few ready calls. Signed-off-by: Niladri Halder <[email protected]>
niladrih
force-pushed
the
healthz-test
branch
from
8245991 to
0e478f7
Compare
tiagolobocastro
approved these changes
Dec 9, 2024
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The current RwLock lets multiple tokio threads probe the agent-core. This is not
ideal. This change makes the get operation atomic, so that agent-core state cache
updates could be performed by only a single thread, and the updated cache should
feed the next few ready calls.