Skip to content

Cherry pick csi-trace and csi-node uri fixes to develop#901

Merged
bors-openebs-mayastor[bot] merged 2 commits intorelease/2.7from
fix-trace-rel
Dec 11, 2024
Merged

Cherry pick csi-trace and csi-node uri fixes to develop#901
bors-openebs-mayastor[bot] merged 2 commits intorelease/2.7from
fix-trace-rel

Conversation

@tiagolobocastro
Copy link
Copy Markdown
Member

@tiagolobocastro tiagolobocastro commented Dec 9, 2024

chore(bors): merge pull request #903

903: fix(csi/stage): fetch uri via REST r=tiagolobocastro a=tiagolobocastro

On a NodeStage call, it's possible that the publish_context URI is out of date. This can happen when the volume has been moved to another node, and the app pod is pinned to a node and the node restarts.
See Mayastor Issue 1781 for more details.

For this fix, we add a new option to enable rest client for the csi-node. Ideally we'd like to strictly adhere to CSI spec, and avoid doing any mayastor specific operations (effectively being a mostly generic nvme-connect csi-driver but the immutability of the publish_context makes this a bit difficult.

Anyways, we add a new flag --enable-rest which is optional, thus still allowing us to run without this layer.
This will be enabled by default on the helm chart.

We also further check for the Nexus Online/Degraded state, which should help avoid a bunch of nvme connect errors in the kernel.

With this, we can also improve a few things down the line, such as ensuring resize before publish, etc... but we should take these 1 at a time and not suddendly do everything via rest...

Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

fix(csi-driver): trace was mistakenly added as info

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
903: fix(csi/stage): fetch uri via REST r=tiagolobocastro a=tiagolobocastro

On a NodeStage call, it's possible that the publish_context URI is out of date. This can happen when the volume has been moved to another node, and the app pod is pinned to a node and the node restarts.
See Mayastor Issue 1781 for more details.

For this fix, we add a new option to enable rest client for the csi-node. Ideally we'd like to strictly adhere to CSI spec, and avoid doing any mayastor specific operations (effectively being a mostly generic nvme-connect csi-driver but the immutability of the publish_context makes this a bit difficult.

Anyways, we add a new flag --enable-rest which is optional, thus still allowing us to run without this layer.
This will be enabled by default on the helm chart.

We also further check for the Nexus Online/Degraded state, which should help avoid a bunch of nvme connect errors in the kernel.

With this, we can also improve a few things down the line, such as ensuring resize before publish, etc... but we should take these 1 at a time and not suddendly do everything via rest...

Co-authored-by: Tiago Castro <tiagolobocastro@gmail.com>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro tiagolobocastro changed the title fix(csi-driver): trace was mistakenly added as info Cherry pick csi-trace and csi-node uri fixes to develop Dec 11, 2024
@tiagolobocastro
Copy link
Copy Markdown
Member Author

bors merge

@bors-openebs-mayastor
Copy link
Copy Markdown

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor Bot merged commit e5e8342 into release/2.7 Dec 11, 2024
@bors-openebs-mayastor bors-openebs-mayastor Bot deleted the fix-trace-rel branch December 11, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants