fix(topology): use topology when decreasing replicas #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih,
abhilashshetty04 and
dsharma-dc
tiagolobocastro
force-pushed
the
replica-dec-top
branch
from
5947898 to
8ac6b84
Compare
tiagolobocastro
commented
Dec 17, 2024
| volume_pool_topology_inclusion_labels = labelled_topology.inclusion | ||
| } else { | ||
| if labelled_topology.inclusion.is_empty() { | ||
| // todo: missing exclusion check? |
There was a problem hiding this comment.
@sinhaashish do we need to take into account exclusion labels on filter?
I guess we're not making use of it atm?
When removing volume replicas, take the topology into account and prefer to remove replicas which don't line up with the volume topology. This can happen when a volume's topology has been modified. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
replica-dec-top
branch
from
8ac6b84 to
75fadc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing volume replicas, take the pool topology into account and prefer to remove replicas which don't line up with the volume topology. This can happen when a volume's topology has been modified.