Cherry-pick PR 579 and PR 584 #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Dec 13, 2024
tiagolobocastro
commented
Don't update the chart on a pre-release Set missing base branch for pull-request Add stricter release validation Add more tests Signed-off-by: Tiago Castro <[email protected]>
Replace hard coded patch and minor values of 0, with values derived from the chart version That way we get versions derived from chart/Chart.yaml, like 2.7.2-... instead of hard coded values like 2.7.0-... or 2.0.0-.... Signed-off-by: Blaise Dias <[email protected]>
tiagolobocastro
requested review from
sinhaashish,
Abhinandan-Purkait,
niladrih and
abhilashshetty04
niladrih
approved these changes
Dec 13, 2024
Abhinandan-Purkait
approved these changes
Dec 14, 2024
sinhaashish
approved these changes
Dec 16, 2024
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
588: Cherry-pick PR 579 and PR 584 r=tiagolobocastro a=tiagolobocastro
chore: fix helm-testing versioning in publish-chart-yaml
Replace hard coded patch and minor values of 0,
with values derived from the chart version
That way we get versions derived from chart/Chart.yaml,
like 2.7.2-... instead of hard coded values like 2.7.0-... or 2.0.0-....
Signed-off-by: Blaise Dias <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
Co-authored-by: Blaise Dias <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"template-chart\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
|
Network error it seems... |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
588: Cherry-pick PR 579 and PR 584 r=tiagolobocastro a=tiagolobocastro
chore: fix helm-testing versioning in publish-chart-yaml
Replace hard coded patch and minor values of 0,
with values derived from the chart version
That way we get versions derived from chart/Chart.yaml,
like 2.7.2-... instead of hard coded values like 2.7.0-... or 2.0.0-....
Signed-off-by: Blaise Dias <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
Co-authored-by: Blaise Dias <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"template-chart\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.