-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pytest): make test more robust and easier to debug #598
Open
tiagolobocastro
wants to merge
7
commits into
develop
Choose a base branch
from
pytest
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Jan 9, 2025
•
edited
Loading
edited
bors try |
tryBuild failed: |
Change a lot of return Nones for exceptions which aids debugging by failing at the point of failure Reduce verbose logging when install/upgrades takes some time due to cpu or network constraints Remove extra logging Allow using kubectl plugin from path I think the tests are currently broken for release branches as its asserting for develop. Also we're modifying the chart itself, which is not ideal. todo: improve this Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
pytest
branch
2 times, most recently
from
January 10, 2025 13:36
f82d8b0
to
be41609
Compare
When deploying a kind cluster, ensure we allocate the requested hugepages. Signed-off-by: Tiago Castro <[email protected]>
Ensure install is properly completed Ensure upgrade is properly completed Compare against v-next and not v-next since there's no current way of knowing which version is the current helm chart. This may get addressed if we start building the images and the chart as v-next from the outset. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
pytest
branch
5 times, most recently
from
January 13, 2025 14:26
d647b79
to
cadbe0c
Compare
tiagolobocastro
changed the title
refactor(pytest): make debugging easier
refactor(pytest): make test more robust and easier to debug
Jan 13, 2025
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
pytest
branch
3 times, most recently
from
January 14, 2025 11:52
4b6ec90
to
10d1a92
Compare
Allows the bdd tests to run and setup the vnext chart on their own We can still pre-deploy the kind cluster on CI for time tracking Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
pytest
branch
from
January 14, 2025 12:24
10d1a92
to
3fe353c
Compare
When pushing tags (annotated?), github's event.base_ref may not be set. When this happens, we can figure out the released branch ourselves, by inspecting all branches containing the tag, and ensuring it's the tip and it's the current HEAD. Signed-off-by: Tiago Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.