Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pytest): make test more robust and easier to debug #598

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

tiagolobocastro
Copy link
Contributor

@tiagolobocastro tiagolobocastro commented Jan 9, 2025

refactor(nix): make shell nix depend on other shells

Signed-off-by: Tiago Castro <[email protected]>

ci(bdd): use larger runner for testing

Signed-off-by: Tiago Castro <[email protected]>

test(bdd): make test more robust

Ensure install is properly completed
Ensure upgrade is properly completed
Compare against v-next and not v-next since there's no current way
of knowing which version is the current helm chart.
This may get addressed if we start building the images and the
chart as v-next from the outset.

Signed-off-by: Tiago Castro <[email protected]>

test: ensure hugepages allocated

When deploying a kind cluster, ensure we allocate the requested hugepages.

Signed-off-by: Tiago Castro <[email protected]>

refactor(pytest): make debugging easier

Change a lot of return Nones for exceptions which aids debugging by
failing at the point of failure
Reduce verbose logging when install/upgrades takes some time due to
cpu or network constraints
Remove extra logging
Allow using kubectl plugin from path

I think the tests are currently broken for release branches as its
asserting for develop.
Also we're modifying the chart itself, which is not ideal.
todo: improve this

Signed-off-by: Tiago Castro <[email protected]>

@tiagolobocastro
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 9, 2025
@bors-openebs-mayastor
Copy link
Contributor

try

Build failed:

Change a lot of return Nones for exceptions which aids debugging by
failing at the point of failure
Reduce verbose logging when install/upgrades takes some time due to
cpu or network constraints
Remove extra logging
Allow using kubectl plugin from path

I think the tests are currently broken for release branches as its
asserting for develop.
Also we're modifying the chart itself, which is not ideal.
todo: improve this

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro tiagolobocastro force-pushed the pytest branch 2 times, most recently from f82d8b0 to be41609 Compare January 10, 2025 13:36
When deploying a kind cluster, ensure we allocate the requested hugepages.

Signed-off-by: Tiago Castro <[email protected]>
Ensure install is properly completed
Ensure upgrade is properly completed
Compare against v-next and not v-next since there's no current way
of knowing which version is the current helm chart.
This may get addressed if we start building the images and the
chart as v-next from the outset.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro tiagolobocastro force-pushed the pytest branch 5 times, most recently from d647b79 to cadbe0c Compare January 13, 2025 14:26
@tiagolobocastro tiagolobocastro changed the title refactor(pytest): make debugging easier refactor(pytest): make test more robust and easier to debug Jan 13, 2025
@tiagolobocastro tiagolobocastro force-pushed the pytest branch 3 times, most recently from 4b6ec90 to 10d1a92 Compare January 14, 2025 11:52
Allows the bdd tests to run and setup the vnext chart on their own
We can still pre-deploy the kind cluster on CI for time tracking

Signed-off-by: Tiago Castro <[email protected]>
When pushing tags (annotated?), github's event.base_ref may not be set.
When this happens, we can figure out the released branch ourselves, by
inspecting all branches containing the tag, and ensuring it's the tip
and it's the current HEAD.

Signed-off-by: Tiago Castro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant