Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): use openebs' lib-csi k8s client to load kubeconfig #645

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

dionysius
Copy link
Contributor

@dionysius dionysius commented Mar 14, 2025

Pull Request template

Why is this PR required? What issue does it fix?: The binary crashes if you want to use it with a kubeconfig stating it can't find the kubeconfig. The package variables kubeconfig and masterurl were never holding a value.

What this PR does?: Uses existing implementation to find kubeconfig. This is already in use in package zfsnode.

Does this PR require any upgrade changes?: no

If the changes in this PR are manually verified, list down the scenarios covered:: starts up binary successfully with env OPENEBS_IO_KUBE_CONFIG set and in agent plugin mode.

Any additional information for your reviewer? : no (see linked issue)

Checklist:

@dionysius dionysius requested a review from a team as a code owner March 14, 2025 02:34
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (8c402d3) to head (d4ba8de).
Report is 55 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #645      +/-   ##
===========================================
- Coverage    95.99%   95.91%   -0.08%     
===========================================
  Files            1        1              
  Lines          574      686     +112     
===========================================
+ Hits           551      658     +107     
- Misses          19       23       +4     
- Partials         4        5       +1     
Flag Coverage Δ
bddtests 95.91% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abhinandan-Purkait
Copy link
Member

@dionysius Are we good to merge?

@Abhinandan-Purkait
Copy link
Member

Will merge once CI passes. Thank you!

@Abhinandan-Purkait Abhinandan-Purkait merged commit 2a6e2d7 into openebs:develop Mar 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node agent: allow running out of cluster using $KUBECONFIG
4 participants