Skip to content

fix: confirmation window is displayed after save for dropdown #2429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: confirmation window is displayed after save for dropdown #2429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/editors/containers/ProblemEditor/components/EditProblemView/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ export const checkForNoAnswers = ({ openSaveWarningModal, problem }) => {
let correctAnswer;
answers.forEach(answer => {
if (answer.correct) {
const title = simpleTextAreaProblems.includes(problemType) ? answer.title : answerTitles[answer.id];
if (title?.length > 0) {
const title = simpleTextAreaProblems.includes(problemType) ? answer.title.toString() : answerTitles[answer.id];
Copy link
Contributor

@bradenmacdonald bradenmacdonald Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem, but it seems like the real problem is that answer.title is a number in the first place. Shouldn't we try to prevent title from being set to a non-string value in the first place, rather than fixing it here?

I think the root problem might be on this line where the XML parser sometimes returns a number for the #text value. Could we coerce it to a string there instead?

if (title.length > 0) {
Copy link
Contributor

@bradenmacdonald bradenmacdonald Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we certain that title is always going to be defined? There's no type information here so I don't really know, but it seems safer to leave it as title?.length just in case.

correctAnswer = true;
}
}
Expand Down
16 changes: 16 additions & 0 deletions src/editors/containers/ProblemEditor/components/EditProblemView/hooks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,22 @@ describe('EditProblemView hooks parseState', () => {
expect(openSaveWarningModal).toHaveBeenCalled();
expect(content).toEqual(null);
});
it('should return the correct content if the user entered a number as the correct answer for a dropdown type problem', () => {
const problem = { ...problemState, answers: [{ id: 'A', title: 1234, correct: true }] };
const content = hooks.getContent({
isAdvancedProblemType: false,
problemState: problem,
editorRef,
assets,
lmsEndpointUrl,
openSaveWarningModal,
});
expect(openSaveWarningModal).toHaveBeenCalled();
expect(content).toEqual({
olx: mockBuiltOLX,
settings: expectedSettings,
});
});
});
});

Expand Down