-
Couldn't load subscription status.
- Fork 163
fix: self-closing script tag fixed for TinyMceEditor #2510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: self-closing script tag fixed for TinyMceEditor #2510
Conversation
|
Thanks for the pull request, @marslanabdulrauf! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
A self-closing So: I don't think we want to encourage users to write self-closing tags, nor care what happens if they do. However, if this is a change in behavior and is breaking existing course content, that would be a different story. |
Friendly ping on this, @marslanabdulrauf! |
Related Ticket (internal)
https://github.com/mitodl/hq/issues/7208
Description
In some scenarios the script tag is automatically enclosing other html content when used in a text component. Take for example this simple piece of html:
if that is put into a text component using the HTML editor, then problems arise, see screenshots:
Basically what happens is the editor is deciding that the script tag needs closed, it then saves the html as:
Testing instructions
This is contentin the editorBest Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'