Skip to content

feat: Make selectable component cards & Component Info Sidebar [FC-0114]#2880

Open
ChrisChV wants to merge 11 commits intoopenedx:masterfrom
open-craft:chris/FAL-4325-selectable-components
Open

feat: Make selectable component cards & Component Info Sidebar [FC-0114]#2880
ChrisChV wants to merge 11 commits intoopenedx:masterfrom
open-craft:chris/FAL-4325-selectable-components

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Feb 13, 2026

Description

image

Supporting information

Testing instructions

  • Use this branch of edx-platform feat: Make selectable component cards [FC-0114] openedx-platform#38010
  • Run tutor dev exec cms npm run build-dev
  • Go to the course outline of a course
  • Add a unit.
  • Open the align sidebar using the Manage tags menu in the unit card. Verify that the unit card is selected.
  • Open the unit page of the new unit.
  • Add some components.
  • Select a component by clicking the header part of the card. Verify the component info sidebar is open. Verify that the Add button in the sidebar navbar is disabled.
  • Open the align sidebar using the Manage tags menu in the component card. Verify that the component card is selected.

Other information

N/A

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 13, 2026

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 13, 2026
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 13, 2026
@ChrisChV ChrisChV changed the title feat: Make selectable component cards & Component Info Sidebar feat: Make selectable component cards & Component Info Sidebar [FC-0114] Feb 13, 2026
@ChrisChV ChrisChV marked this pull request as draft February 13, 2026 23:18
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

❌ Patch coverage is 98.43750% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.24%. Comparing base (c39923f) to head (9c5fd24).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...it/unit-sidebar/unit-info/ComponentInfoSidebar.tsx 97.14% 1 Missing ⚠️
...ic/library-reference-card/LibraryReferenceCard.tsx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
+ Coverage   95.22%   95.24%   +0.01%     
==========================================
  Files        1332     1335       +3     
  Lines       30551    30626      +75     
  Branches     6678     6906     +228     
==========================================
+ Hits        29093    29169      +76     
+ Misses       1401     1388      -13     
- Partials       57       69      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV marked this pull request as ready for review February 16, 2026 22:10
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChV Overall the changes look good.

Found one small issue: if the selected block is deleted, the sidebar should revert to unit info. Currently the block is still displayed in the sidebar.

Also, the add button on sidebar is disabled when a component is selected but the top level Add still works. I think disabling we should not disable the top level add button, instead if the author clicks on it the sidebar should revert to unit add. Currently it shows the add sidebar correctly but the component is still selected and shown in other tabs in the sidebar.

@ChrisChV
Copy link
Contributor Author

@ChrisChV Overall the changes look good.

Found one small issue: if the selected block is deleted, the sidebar should revert to unit info. Currently the block is still displayed in the sidebar.

Also, the add button on sidebar is disabled when a component is selected but the top level Add still works. I think disabling we should not disable the top level add button, instead if the author clicks on it the sidebar should revert to unit add. Currently it shows the add sidebar correctly but the component is still selected and shown in other tabs in the sidebar.

@navinkarkera Nice catch! I fixed those issues in 8cea5cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

3 participants