fix(deps): update pins for successful lockfile regen - #3179
Merged
bradenmacdonald merged 2 commits intoJul 28, 2026
Conversation
…k.json new minor versions of oxlint have peer deps on new zero-version minor versions of oxlint-tsgolint. ^ pins the leftmost non-zero version number, so a lockfileless npm install was failing. node types were pulled in as 26.x before pinning leading to npm run types failing. pinned to ^25 to match the pre-regen lockfile..
fast-xml-parser 5.3.8+ ships breaking XMLBuilder behavior changes in patch/minor releases (5.3.8 serializes empty preserveOrder nodes as "[object Object]"; 5.7.3 escapes apostrophes in attribute values), which break the ProblemEditor OLX builder/parser on a lockfile regen. Pin to 5.3.7, the last release before either regression, so the lockfile can be regenerated safely. Moving to latest (and the security bump in openedx#3175) is tracked in openedx#3178. Refs openedx#3178 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3179 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 1398 1398
Lines 33473 33528 +55
Branches 7886 7885 -1
=======================================
+ Hits 32064 32119 +55
- Misses 1350 1365 +15
+ Partials 59 44 -15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bradenmacdonald
approved these changes
Jul 28, 2026
bradenmacdonald
left a comment
bradenmacdonald
left a comment
Contributor
There was a problem hiding this comment.
I did some smoke tests, and this looks good. Thanks for taking care of this!
Contributor
|
BTW, I believe that the problem with
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
I used claude to diagnose the
fast-xml-parserstuffDescription
Regenerating the lockfile failed when I first tried. I was able regen by pinning
oxlint(part of db8a761).After regen, type check was failing, I addressed this by pinning
types/node(also in db8a761)Tests were then failing, narrowed down to
fast-xml-parser. Details in #3178. Addressed by pinning in c489319.