Skip to content

feat(taxonomy): add CompetencyManagementPage - #3227

Closed
javoconsultant wants to merge 8 commits into
openedx:masterfrom
javoconsultant:663-competency-management-page
Closed

feat(taxonomy): add CompetencyManagementPage#3227
javoconsultant wants to merge 8 commits into
openedx:masterfrom
javoconsultant:663-competency-management-page

Conversation

@javoconsultant

@javoconsultant javoconsultant commented Sep 2, 2026

Copy link
Copy Markdown

Description

Recording.at.2026-09-02.15.26.24.mp4

Supporting information

openedx/openedx-core#663

Testing instructions

Setup: you'll need at least one taxonomy with type Competency and one with type Tags to see the different behaviors (this depends on the taxonomy_type field from #616 being present on the API response — set it directly in the DB/fixture if the backend doesn't support it yet).

  1. Card footer button (list page)

    • Open Studio HomeTaxonomies tab.
    • Find a Competency-type taxonomy card where you have edit permissions. Confirm it now shows an "Apply Competencies" button in a footer at the bottom of the card.
    • Click Apply Competencies and confirm it navigates to /taxonomy/<id>/competencies (not to the regular taxonomy detail page), without also triggering the card's own link (clicking should not fire twice / navigate twice).
    • Confirm the card's title area is still a link to /taxonomy/<id>/ (i.e. clicking the card body/header, not the button, still opens the normal taxonomy detail page).
    • Confirm a Tags-type taxonomy card shows no footer/button.
    • If you have a competency taxonomy but lack edit permission (canChangeTaxonomy: false — e.g. log in as a role without edit rights, or check via a user who isn't course-team staff), confirm the footer button does not appear.
    • Check card layout: with the footer showing, confirm the description text still clamps/truncates cleanly (no overflow past the card bounds) and the footer stays pinned to the bottom of the card.
  2. Kebab menu item

    • On that same competency taxonomy card (or on the taxonomy detail page), open the menu.
    • Confirm "Apply Competencies" appears as the last item in the menu (after Re-import/Export/Delete/Manage Organizations, as applicable).
    • Click it and confirm it navigates to /taxonomy/<id>/competencies.
    • Open the menu on a Tags taxonomy and confirm Apply Competencies is absent.
    • Open the menu on a competency taxonomy as a user without edit permission and confirm it's absent too.
  3. Competency Management page itself

    • Navigate directly to /taxonomy/<id>/competencies for a valid competency taxonomy.
    • Confirm it shows a loading spinner briefly, then a breadcrumb (Taxonomies → taxonomy name) and the taxonomy name as the page title/heading and browser tab title.
    • Confirm clicking Taxonomies in the breadcrumb navigates back to /taxonomies/.
    • Note: this page is currently a placeholder (breadcrumb + title only) — no competency tree/content yet, so there's nothing further to exercise here.
    • Navigate to /taxonomy/<bad-or-nonexistent-id>/competencies and confirm the connection-error alert is shown instead of a crash.

Other information

Dependencies:
#3208
#3226

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 2, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @javoconsultant!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@javoconsultant javoconsultant self-assigned this Sep 2, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Sep 2, 2026
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.25373% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.94%. Comparing base (16e19f1) to head (5f6da35).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/taxonomy/import-tags/steps/UploadStep.tsx 96.00% 1 Missing ⚠️
src/taxonomy/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3227      +/-   ##
==========================================
+ Coverage   95.92%   95.94%   +0.01%     
==========================================
  Files        1397     1412      +15     
  Lines       33581    33704     +123     
  Branches     7947     7711     -236     
==========================================
+ Hits        32214    32336     +122     
- Misses       1308     1325      +17     
+ Partials       59       43      -16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@javoconsultant
javoconsultant force-pushed the 663-competency-management-page branch from 7d91c25 to 5f6da35 Compare September 2, 2026 10:47
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants