feat: upgrade react to v18#759
Merged
brian-smith-tcril merged 3 commits intomasterfrom Apr 9, 2025
Merged
Conversation
Closed
Closed
Contributor
|
Thanks for opening this! Looks like CI is failing on |
huniafatima-99
force-pushed
the
hunia/react-18-upgrade
branch
from
89ed5a9 to
352a154
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #759 +/- ##
==========================================
- Coverage 93.17% 93.15% -0.03%
==========================================
Files 161 161
Lines 3401 3402 +1
Branches 919 923 +4
==========================================
Hits 3169 3169
Misses 215 215
- Partials 17 18 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
brian-smith-tcril
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
awais-ansari
approved these changes
Apr 9, 2025
sundasnoreen12
approved these changes
Apr 9, 2025
Contributor
brian-smith-tcril
left a comment
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Overall this is looking great! I left a couple comments about changes to the tests, but once those are addressed this should be good to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades react from v17 to v18.
Issue link
#753