Skip to content

Conversation

jansenk
Copy link
Contributor

@jansenk jansenk commented Jul 29, 2025

Adds a plugin slot, org.openedx.frontend.learning.content_iframe_error.v1 to enable customization via plugins of the error page shown when the unit iframe fails to load.

@jansenk jansenk force-pushed the jkantor/unit-error-slot branch from 49e16c7 to 25b0ddb Compare July 29, 2025 17:55
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (6892633) to head (215604d).
⚠️ Report is 27 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1771   +/-   ##
=======================================
  Coverage   90.38%   90.39%           
=======================================
  Files         344      345    +1     
  Lines        5811     5817    +6     
  Branches     1355     1398   +43     
=======================================
+ Hits         5252     5258    +6     
+ Misses        542      540    -2     
- Partials       17       19    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jansenk jansenk requested a review from Copilot July 29, 2025 18:01
Copilot

This comment was marked as resolved.

@jansenk jansenk requested a review from Copilot July 29, 2025 19:45
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new plugin slot to enable customization of the error page displayed when content iframe fails to load in the learning application. The plugin slot allows developers to replace or modify the default error page with custom implementations.

  • Creates a new ContentIFrameErrorSlot plugin slot component with slot ID org.openedx.frontend.learning.content_iframe_error.v1
  • Replaces the direct usage of ErrorPage component with the new plugin slot in the ContentIFrame component
  • Provides documentation and configuration examples for the new plugin slot

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/plugin-slots/ContentIFrameErrorSlot/index.tsx Creates the new plugin slot component that wraps ErrorPage as default content
src/plugin-slots/ContentIFrameErrorSlot/README.md Provides documentation and usage examples for the plugin slot
src/courseware/course/sequence/Unit/ContentIFrame.jsx Updates error handling to use the new plugin slot instead of ErrorPage directly

@jansenk jansenk merged commit f91af21 into master Oct 20, 2025
7 checks passed
@jansenk jansenk deleted the jkantor/unit-error-slot branch October 20, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants