Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add language selector component to header #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ang-m4
Copy link

@Ang-m4 Ang-m4 commented Apr 2, 2025

Language Selector Implementation

Description

This pull request proposes a new LanguageSelector component that enables users to change the site language using a paragon dropdown.

Features

  • Responsive design that shows:
    • Only the language icon on small screens (< 576px)
    • Language code (e.g., "EN") on medium screens (576px-767px)
    • Full language name (e.g., "English") on large screens (≥ 768px)
  • Configurable through platform settings

Changes

  • LanguageSelector.jsx: Main component implementation
  • LanguageSelector.scss: Styling with media queries
  • LanguageSelector.test.jsx: Testing logic for the component
  • index.js: Export file for the component

Integration

The component is integrated into both header types:

  • Added to LearningHeader.jsx for the learning experience
  • Added to HeaderBody.jsx for Studio

Both implementations are conditional based on the ENABLE_HEADER_LANG_SELECTOR configuration flag, making it easy to enable/disable.

Related Work

This implementation relies entirely on the proposed LanguageManagement feature. For more details, please refer to the related pull request: Language Management PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 2, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 2, 2025

Thanks for the pull request, @Ang-m4!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@Ang-m4
Copy link
Author

Ang-m4 commented Apr 3, 2025

Hey @dcoa! 😊 I built on your changes from your PR and would love for you to take a look when you have a chance. Let me know what you think! Thanks!

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U
Projects
Status: Needs Tests Run or CLA Signed
Development

Successfully merging this pull request may close these issues.

3 participants