fix: calculate last_grade_publish_date for all unreleased subsections#37748
fix: calculate last_grade_publish_date for all unreleased subsections#37748asajjad2 wants to merge 1 commit intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @asajjad2! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| if subsection_grade.due: | ||
| should_update = ( | ||
| bucket.last_grade_publish_date is None or | ||
| subsection_grade.due > bucket.last_grade_publish_date | ||
| ) | ||
| if should_update: | ||
| bucket.last_grade_publish_date = subsection_grade.due |
There was a problem hiding this comment.
@asajjad2 could you add test(s) for this change?
00b942b to
6bc3a2c
Compare
| if 'last_grade_publish_date_days' in expected: | ||
| expected_date = ( | ||
| datetime.now(timezone.utc) + | ||
| timedelta(days=expected['last_grade_publish_date_days']) | ||
| ) | ||
| assert row['last_grade_publish_date'] is not None | ||
| else: | ||
| assert row['last_grade_publish_date'] is None |
There was a problem hiding this comment.
This can be simplified to:
| if 'last_grade_publish_date_days' in expected: | |
| expected_date = ( | |
| datetime.now(timezone.utc) + | |
| timedelta(days=expected['last_grade_publish_date_days']) | |
| ) | |
| assert row['last_grade_publish_date'] is not None | |
| else: | |
| assert row['last_grade_publish_date'] is None | |
| assert (row['last_grade_publish_date'] is not None) == ( | |
| 'last_grade_publish_date_days' in expected | |
| ) |
f5f8343 to
c65e1fa
Compare
743126a to
bc7f8ed
Compare
|
@asajjad2 can you squash your commits and rebase? |
b4e5502 to
658767f
Compare
fix: don't update business logic fix: comparison condition fix: linting errors fix: linting error test: progress api test test: add not-null scenario fix: linting errors test: fix assertion refactor: tests
658767f to
b3b1c2c
Compare
What are the relevant tickets?
#9459
Description (What does it do?)
The
last_grade_publish_datefield for each section in the progress API was showing the current datetime instead of the actual grade release date when there were no unreleased subsections withshow_correctnessvalues of'past_due'or'never_but_include_grade'.The original code only initialized
last_grade_publish_datetonow()and updated only when:show_correctness(Assessment result visibility) was in['past_due', 'never_but_include_grade']andlast_grade_publish_dateThis PR updates the code to initialize
last_grade_publish_datefromnow()toNoneTesting Steps
Some assignment scores are not yet included in your total grade. These grades will be released by {current date}