Extract Video Block from edx-platform | Update the shifted Video XBlock code#142
Open
farhan wants to merge 11 commits intofarhan/video-block-lift-and-siftfrom
Open
Extract Video Block from edx-platform | Update the shifted Video XBlock code#142farhan wants to merge 11 commits intofarhan/video-block-lift-and-siftfrom
farhan wants to merge 11 commits intofarhan/video-block-lift-and-siftfrom
Conversation
farhan
force-pushed
the
farhan/update-shifted-video-block-code
branch
from
102abb6 to
6a3edee
Compare
farhan
changed the title
This was referenced Jan 26, 2026
farhan
force-pushed
the
farhan/update-shifted-video-block-code
branch
from
9415c91 to
cd2263a
Compare
Member
|
Upon taking a skim through it, I don't see any issues. @farhan can you have a team member review, and merge it if it looks good to both of you? |
farhan
force-pushed
the
farhan/video-block-lift-and-sift
branch
from
d684cf3 to
0c374ea
Compare
farhan
force-pushed
the
farhan/update-shifted-video-block-code
branch
from
e4a858c to
fc8cafa
Compare
farhan
force-pushed
the
farhan/update-shifted-video-block-code
branch
from
fc8cafa to
302af97
Compare
irtazaakram
requested changes
Feb 13, 2026
| @@ -0,0 +1,3 @@ | |||
| node_modules/* | |||
Member
There was a problem hiding this comment.
Lets move this to root .gitignore
Comment on lines
+7
to
+10
| "scripts": { | ||
| "build": "webpack --config webpack.prod.config.js", | ||
| "build-dev": "webpack --config webpack.dev.config.js", | ||
| "test": "echo \"Error: no test specified\" && exit 1" |
Member
There was a problem hiding this comment.
We need to make our root package.json have these commands for it to run.
| EmptyDataRawMixin, XmlMixin, EditingMixin, XModuleToXBlockMixin, | ||
| ResourceTemplates, XModuleMixin, LicenseMixin): | ||
| @XBlock.wants('settings', 'completion', 'request_cache', 'video_config') | ||
| @XBlock.needs('i18n', 'user') |
Member
There was a problem hiding this comment.
what made us move i18n from wants to needs?
| return urlunsplit((scheme, netloc, path, new_query_string, fragment)) | ||
|
|
||
|
|
||
| def deserialize_field(field, value): |
Member
There was a problem hiding this comment.
Comment on lines
+13
to
+23
| "draggabilly": "^3.0.0", | ||
| "edx-ui-toolkit": "1.8.7", | ||
| "hls.js": "0.14.17", | ||
| "underscore": "^1.13.7", | ||
| "webpack-merge": "^6.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "clean-webpack-plugin": "^4.0.0", | ||
| "webpack": "^5.99.8", | ||
| "webpack-cli": "^6.0.1", | ||
| "webpack-manifest-plugin": "^5.0.1" |
Member
There was a problem hiding this comment.
Are these packages versions inline with edx-platform/package.json?
| ] | ||
| }; | ||
|
|
||
| module.exports = config |
Member
There was a problem hiding this comment.
we need to confirm that the bundle produced by this is exactly the same as that of edx-platform's one. Right now I can see alot of differences between both
| tabindex="-1" | ||
| > | ||
| data-package-name="xblocks-contrib" | ||
| data-test-id="1"> |
Comment on lines
+342
to
+346
| fragment.add_css(loader.load_unicode("static/css/video.css")) | ||
| fragment.add_javascript_url( | ||
| self.runtime.local_resource_url(self, self._video_js_resource_path()) | ||
| ) | ||
| fragment.initialize_js("Video") |
Member
There was a problem hiding this comment.
Shouldn't we load both from runtime?
Suggested change
| fragment.add_css(loader.load_unicode("static/css/video.css")) | |
| fragment.add_javascript_url( | |
| self.runtime.local_resource_url(self, self._video_js_resource_path()) | |
| ) | |
| fragment.initialize_js("Video") | |
| fragment.add_css(self.runtime.local_resource_url(self, "public/css/video.css")) | |
| fragment.add_javascript_url( | |
| self.runtime.local_resource_url(self, self._video_js_resource_path()) | |
| ) | |
| fragment.initialize_js("Video") |
| return metadata_fields | ||
|
|
||
| @property | ||
| def editable_metadata_fields(self): |
Member
There was a problem hiding this comment.
we should've kept it in video block to minimize change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Description:
Code has been updated in this PR to make Video Block independent from the edx-platform.
edx-platformtest cases PRedx-platform) PRExtracted Video XBlock Sandbox to test the whole extraction: sandbox-pr
Testing Notes:
Extracted Video XBlock can be manually tested on the local machine setup up.
Known Issues/Pending Stories in Video XBlock Extraction:
edx-platformprior work:Following is the prior work already done in the
edx-platformto decouple Video Block from platform by introducingVideoConfigServiceopenedx/openedx-platform#37829
openedx/openedx-platform#37809
openedx/openedx-platform#37808
openedx/openedx-platform#37793
openedx/openedx-platform#37779
openedx/openedx-platform#37776
openedx/openedx-platform#37635
openedx/openedx-platform#37631
openedx/openedx-platform#37459