Extract Video Block from edx-platform | Update the shifted Video XBlock code by farhan · Pull Request #142 · openedx/xblocks-contrib

farhan · 2026-01-23T12:25:09Z

Ticket

Description:

Code has been updated in this PR to make Video Block independent from the edx-platform.

Quality fixes ✅ have been done in this child PR for the ease of code review of this PR.
Predecessor PR having source (lift & shift code)
edx-platform test cases PR
Video block test cases (migrating from edx-platform) PR
Karma test cases PR that will be merged after this PR

Extracted Video XBlock Sandbox to test the whole extraction: sandbox-pr

Testing Notes:

Review the predecessor PR and make sure all the original code has been lifted and shifted correctly.
Review this PR

Extracted Video XBlock can be manually tested on the local machine setup up.

Known Issues/Pending Stories in Video XBlock Extraction:

Transcripts handling: Feature break | Uploaded transcripts on Video Editor are not appearing | Extracted Video Block public-engineering#487
Video XBlock is not rending on the sandbox which will be fixed in story
Thorough testing of Extracted Video XBlock is pending

`edx-platform` prior work:

Following is the prior work already done in the edx-platform to decouple Video Block from platform by introducing VideoConfigService
openedx/openedx-platform#37829
openedx/openedx-platform#37809
openedx/openedx-platform#37808
openedx/openedx-platform#37793
openedx/openedx-platform#37779
openedx/openedx-platform#37776
openedx/openedx-platform#37635
openedx/openedx-platform#37631
openedx/openedx-platform#37459

kdmccormick · 2026-02-05T22:00:30Z

Upon taking a skim through it, I don't see any issues. @farhan can you have a team member review, and merge it if it looks good to both of you?

irtazaakram · 2026-02-13T10:30:36Z

xblocks_contrib/video/.gitignore

@@ -0,0 +1,3 @@
+node_modules/*


Lets move this to root .gitignore

irtazaakram · 2026-02-13T11:25:57Z

xblocks_contrib/video/package.json

+  "scripts": {
+    "build": "webpack --config webpack.prod.config.js",
+    "build-dev": "webpack --config webpack.dev.config.js",
+    "test": "echo \"Error: no test specified\" && exit 1"


We need to make our root package.json have these commands for it to run.

irtazaakram · 2026-02-13T11:32:10Z

xblocks_contrib/video/video.py

-        EmptyDataRawMixin, XmlMixin, EditingMixin, XModuleToXBlockMixin,
-        ResourceTemplates, XModuleMixin, LicenseMixin):
+@XBlock.wants('settings', 'completion', 'request_cache', 'video_config')
+@XBlock.needs('i18n', 'user')


what made us move i18n from wants to needs?

I think it should be as its availability check doesn't exist on its usage.

It also in sync up with all other blocks of xblocks-contrib.

irtazaakram · 2026-02-13T12:50:08Z

xblocks_contrib/video/video_utils.py

Can we use https://github.com/openedx/xblocks-contrib/blob/main/xblocks_contrib/common/xml_utils.py#L97

Yes, thanks for pointing it

irtazaakram · 2026-02-13T12:56:50Z

xblocks_contrib/video/package.json

+    "draggabilly": "^3.0.0",
+    "edx-ui-toolkit": "1.8.7",
+    "hls.js": "0.14.17",
+    "underscore": "^1.13.7",
+    "webpack-merge": "^6.0.1"
+  },
+  "devDependencies": {
+    "clean-webpack-plugin": "^4.0.0",
+    "webpack": "^5.99.8",
+    "webpack-cli": "^6.0.1",
+    "webpack-manifest-plugin": "^5.0.1"


Are these packages versions inline with edx-platform/package.json?

There were, going to update them again as changed in following PR
openedx/openedx-platform#37961

irtazaakram · 2026-02-13T12:59:29Z

xblocks_contrib/video/webpack.common.config.js

+    ]
+};
+
+module.exports = config


we need to confirm that the bundle produced by this is exactly the same as that of edx-platform's one. Right now I can see alot of differences between both

irtazaakram · 2026-02-13T13:00:53Z

xblocks_contrib/video/templates/video.html

    tabindex="-1"
->
+    data-package-name="xblocks-contrib"
+    data-test-id="1">


Why do we need this?

Using it for the testing on the sanbox to check the versions, removed ➖

irtazaakram · 2026-02-13T13:07:34Z

xblocks_contrib/video/video.py

+        fragment.add_css(loader.load_unicode("static/css/video.css"))
+        fragment.add_javascript_url(
+            self.runtime.local_resource_url(self, self._video_js_resource_path())
+        )
+        fragment.initialize_js("Video")


Shouldn't we load both from runtime?

Suggested change

fragment.add_css(loader.load_unicode("static/css/video.css"))

fragment.add_javascript_url(

self.runtime.local_resource_url(self, self._video_js_resource_path())

)

fragment.initialize_js("Video")

fragment.add_css(self.runtime.local_resource_url(self, "public/css/video.css"))

fragment.add_javascript_url(

self.runtime.local_resource_url(self, self._video_js_resource_path())

)

fragment.initialize_js("Video")

irtazaakram · 2026-02-13T13:08:42Z

xblocks_contrib/video/studio_metadata_mixin.py

+        return metadata_fields
+
+    @property
+    def editable_metadata_fields(self):


we should've kept it in video block to minimize change.

This commit contains original code copied from edx-platform. Purpose of keeping the first commit with original code is to get help in the review process. Reviewer just needs to open the second commit and code changes will be clearly visible.

farhan force-pushed the farhan/update-shifted-video-block-code branch from 102abb6 to 6a3edee Compare January 23, 2026 13:58

farhan mentioned this pull request Jan 23, 2026

Core Video XBlock extracted from edx-platform #83

Closed

farhan changed the title ~~Update the shifted Video XBlock code to make it run~~ Extract Video Block from edx-platform | Update the shifted Video XBlock code Jan 23, 2026

This was referenced Jan 26, 2026

Lift and shift Video Block code moving from edx-platform #141

Open

Video Block quality fixes #143

Open

Extracted Video Block | Fix xblocks-contrib PR test cases openedx/public-engineering#485

Open

farhan force-pushed the farhan/update-shifted-video-block-code branch from 9415c91 to cd2263a Compare January 30, 2026 13:36

farhan mentioned this pull request Feb 4, 2026

Code Review | Extracted Video XBlock openedx/public-engineering#492

Open

farhan requested review from a team and irtazaakram February 4, 2026 11:33

farhan self-assigned this Feb 4, 2026

farhan mentioned this pull request Feb 4, 2026

enable extracted video block openedx/openedx-platform#37851

Draft

farhan requested a review from kdmccormick February 4, 2026 14:31

kdmccormick removed their request for review February 5, 2026 22:00

farhan force-pushed the farhan/video-block-lift-and-sift branch from d684cf3 to 0c374ea Compare February 10, 2026 12:19

farhan force-pushed the farhan/update-shifted-video-block-code branch 2 times, most recently from fc8cafa to 302af97 Compare February 10, 2026 12:27

irtazaakram requested changes Feb 13, 2026

View reviewed changes

farhan force-pushed the farhan/video-block-lift-and-sift branch from 0c374ea to de657bb Compare February 15, 2026 17:21

farhan added 10 commits February 15, 2026 22:28

feat: Update the shifted Video XBlock code to make it run

557cce3

chore: Adds a method from XModuleMixin of edx-platform

af815ed

chore: Adds studio_view for the compatibility with auth-mfe

6899fc4

chore: remove unwanted make template line

dcb8c7d

chore: test commit for the sandbox issue

06da216

chore: comment resources_dir field

9cc9f4d

fix: fix static url issue

b8dff8a

chore: update static asset url logic

faed2d9

chore: adds edxval in base.in

eb01bfb

farhan added 4 commits February 15, 2026 22:28

chore: run make upgrade

fb1cb67

chore: update url

f7527a8

chore: Address change requests

4cf58ff

chore: fixed rebasing mistake

8155f17

farhan force-pushed the farhan/update-shifted-video-block-code branch from ffa33f7 to 8155f17 Compare February 15, 2026 17:33

chore: update compiled video-xblock js file

93a6d8d

Conversation

farhan commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Testing Notes:

Known Issues/Pending Stories in Video XBlock Extraction:

edx-platform prior work:

Uh oh!

kdmccormick commented Feb 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

farhan commented Jan 23, 2026 •

edited

Loading

`edx-platform` prior work: