Skip to content

Fix Python and JavaScript (Karma) tests for Problem XBlock #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
irtazaakram wants to merge 3 commits into
base: problemblock
Choose a base branch
from
Open

Fix Python and JavaScript (Karma) tests for Problem XBlock #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c52b875
fix: add problem xblock
irtazaakram Feb 9, 2026
c58c32b
fix: npm commands
irtazaakram Feb 9, 2026
9a1a01c
fix: remove xmodule refrences
irtazaakram Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/javascript-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [20]
node-version: [24]

steps:
- name: Check out repository
Expand Down
10 changes: 10 additions & 0 deletions .github/workflows/pypi-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,16 @@ jobs:
with:
python-version: 3.12

- name: Set up Node.js
uses: actions/setup-node@v6
with:
node-version: '24'

- name: Build JavaScript bundles
run: |
npm install
Copy link
Contributor

@salman2013 salman2013 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comment.
https://github.com/openedx/xblocks-contrib/pull/151/changes#r2773284533

Copy link
Member Author

@irtazaakram irtazaakram Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the npm run build step because the package requires the bundled JavaScript and CSS files in the public folder for the problem XBlock. These assets aren’t stored in the repo (public is gitignored) and are only supposed to be included in the published PyPi package.

npm run build

- name: Install dependencies
run: pip install -r requirements/pip.txt

Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ __pycache__
/.installed.cfg
/lib
/lib64
node_modules
public

# Installer logs
pip-log.txt
Expand All @@ -34,6 +36,7 @@ pip-log.txt
.tox
coverage.xml
htmlcov/
coverage/

# Virtual environments
/venv/
Expand Down
Loading
Loading