Separate HtmlBlockMixin base to use in About, StaticTab, CourseInfo - #122
Conversation
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
farhan
left a comment
There was a problem hiding this comment.
1 query, rest all seems good.
Feel free to merge after looking into it.
| return super().non_editable_metadata_fields + [HtmlBlock.xml_attributes, HtmlBlock.use_latex_compiler] | ||
|
|
||
|
|
||
| class HtmlBlock(HtmlBlockMixin): # pylint: disable=abstract-method |
There was a problem hiding this comment.
Which abstract method making this class abstract?
There was a problem hiding this comment.
The studio_view method in HtmlBlockMixin just raises NotImplementedError (line 274), so pylint treats it as abstract. to resolve this ignore it.
Description:
Use extracted HTML block base for About, StaticTab, CourseInfo
Ticket: openedx/openedx-platform#37718 (comment)