Fixes/#116 entsoe py can not be used #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClaraBuettner
requested changes
Aug 14, 2023
There was a problem hiding this comment.
All GitHub checks fail, maybe because the setup file was not adjusted. Cpuld you please have a look at that?
Besides, it would be good to mention in the installation process which and where the file for the entsoe token should be added and how it could be created. We also once thought about using the old version with the downloaded files as a backup in case the direct access is not working.
CarlosEpia
force-pushed
the
fixes/#116-entsoe-py-can-not-be-used
branch
from
e63f1a4
to
dce1800
Compare
| logging.warning( | ||
| """Demand data from entsoe could not be retrieved. | ||
| Backup data is used instead""" | ||
| ) | ||
| load_sq = pd.read_csv( | ||
| "data_bundle_powerd_data/entsoe/load_entsoe.csv", index_col="Index" | ||
| ) |
There was a problem hiding this comment.
These lines now overwrite load_sq always, even if the data was retrieved by the website, right?
There was a problem hiding this comment.
Right. Indentation error. Fixed in f618dad
ClaraBuettner
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116. This was already tested locally.
Each user must now have a hidden text file called ".entsoe-token" allocated in their home directory (in the same directory where the ERA5 password file is stored)
This branch can only be merged once #111